Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Mongoose {strict: throw} doesn't throw error

I tried to find the answer to this question everywhere, but it seems I'm out of luck.

I have a very simple mongoose model

var userObject = {
    profile: {
        username: {
            type: String,
            required: true,
            lowercase: true
        },
        firstname: {
            type: String,
            required: true
        },
        lastname: {
            type: String,
            required: true
        },
        img: {
            type: String,
            required: true,
            match: /^(https?:\/\/)/i
        },
        email: {
            type: String,
            match: /^[a-zA-Z0-9.!#$%&’*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*$/,
            required: true
        },
        singupdate: {
            type: Date,
            default: Date.now
        }
    }
};

And, when I create the schema I choose the option to throw an error when I add properties not in the model.

new mongoose.Schema(userObject, { strict: "throw" });

This is how I tried to catch the error. When I add valid properties the process runs and I recibe the docs created, but when I add invalid properties, the process never exits, and the logs never appear on the console.

try {
    User.create(users, function(err, docs) {
        console.log("err: " + err);
        console.log("docs: " + docs);
    });
} catch (e) {
    console.log(e.message);
}

What am I doing wrong?

like image 965
Leia Avatar asked Jan 01 '17 21:01

Leia


People also ask

Can we overwrite Mongoose default ID with own id?

You can also overwrite Mongoose's default _id with your own _id . Just be careful: Mongoose will refuse to save a document that doesn't have an _id , so you're responsible for setting _id if you define your own _id path.

Does Mongoose auto generate ID?

_id field is auto generated by Mongoose and gets attached to the Model, and at the time of saving/inserting the document into MongoDB, MongoDB will use that unique _id field which was generated by Mongoose.

What is Mongoose strict?

Mongoose is an ODM, and the {strict: true} option in this regard only applies to queries you run through Mongoose, it's not enforced in the mongoDB side, your documents remain schemaless.

Should I use Mongoose validation?

Data validation is important to make sure that “bad” data does not get persisted in your application. A benefit of using Mongoose when inserting data into MongoDB is its built-in support for data schemas, and the automatic validation of data when it is persisted. You would not get this without Mongoose.


2 Answers

The docs say:

https://mongoosejs.com/docs/guide.html#strict

The strict option, (enabled by default), ensures that values passed to our model constructor that were not specified in our schema do not get saved to the db

The strict option may also be set to "throw" which will cause errors to be produced instead of dropping the bad data.

But it doesn't mean what you think it means.

NOTE: Any key/val set on the instance that does not exist in your schema is always ignored, regardless of schema option.

So 'Bad data' just encompasses data that is in the schema but wrong format. Any extra data NOT in the schema will just be silently deleted, causing maximum hair-loss and violating POLA.

like image 126
dcsan Avatar answered Oct 25 '22 08:10

dcsan


If you add properties that are not part of the model, from mongoose doc :

The strict option, (enabled by default), ensures that values passed to our model constructor that were not specified in our schema do not get saved to the db

It is working like this even with strict:throw, so you don't have to worry about additional fields not referenced in the model.

Concerning the exception not triggered, Aaron Heckmann talks about this in this post regarding that an exception that is not triggered on a save with strict : throw :

This is more a misunderstanding of how mongoose works. the 'strict' option enables validation of keys/values that are attempting to be stored in the db. schemas create getters/setters on document instances that delagate to the doc.{g,s}et() methods which are validated. attaching adhoc data to a mongoose document instance doesn't trigger get/set() and as such doesn't warrant validation since there's no way that day can get saved to the db.

As the additional fields are not part of the model, they don't trigger those validation so no exception is triggered (and of course those fields are not saved in the database)

Exceptions will be thrown only if your fields that belong to the model fail this validation

like image 3
Bertrand Martel Avatar answered Oct 25 '22 09:10

Bertrand Martel