Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

looking for a call or thread id to use for logging

Tags:

logging

go

I am reworking the logging of our little web application written in golang. Due to external requirements logging has been isolated in one place so we can potentially switch in a logging server later on. (Not my idea - I promise....) Nevertheless we are now able to log the common things like date/time, line number, user and the message mostly using parts of the standard library and a user/session struct we are passing around.

But - and here comes the question - in lower level methods it is a waste to pass in the session just to get to the user name for the sake of logging. So I would like to find something else to use to find one specific request in the log files. I am sure there are something obvious I haven't thought of.

Ideas so far:

  • Java logging frameworks can print out the thread id and that would be good enough in this case also. Just that it is called something else in golang?
  • make the user/session struct thing accesible globally somehow. (Still need to pass the session id around unless there are a thread to use as lookup key. Back to idea number 1.)
  • give up and pass the user/session struct around anyway.
  • don't log errors on the lowest level but only when the user/session struct is available. The line number won't be that good though.

We are using parts of gorilla for web things and apart from that mostly the standard library.

Suggestions and ideas about this?

like image 854
froderik Avatar asked Oct 01 '13 11:10

froderik


1 Answers

Because of the high potential for abuse, there is no way to access an identifier for the current goroutine in Go. This may seem draconian, but this actually preserves an important property of the Go package ecosystem: it does not matter if you start a new goroutine to do something.

That is, for any method of function F:

F()

is almost exactly equivalent to:

done := make(chan struct{})
go func() {
   defer close(done)
   F()
}
<-done

(The "almost" comes from the fact that if F panics, the panic will not be caught by the original goroutine).

This applies to logging too - if you were using the current goroutine to infer the current user, any code that started a new goroutine as above would break that assumption, and your logging would not contain the expected information.

You'll need to pass around some kind of context.

like image 93
rog Avatar answered Sep 20 '22 12:09

rog