Logging in Java 8 Optional

Question

I have some code where I'm using Java 8 Optional in which I want to log an error when I don't get the required result.

As shown in following Example I have commented on a line where I get the error when I'm trying to log Error Message:

    @PutMapping("/organs/{id}")
    public Organ updateorgan(@PathVariable(value = "id") Long organId,
                                           @Valid @RequestBody Organ organDetails) {

        Organ organ = organRepository.findById(organId)
                .orElseThrow(() -> 
                   // LOG.log(Level.SEVERE,"Organ with id "+organId + "not found");
                   new ResourceNotFoundException("organ", "id", organId)
                );

        organ.setName(organDetails.getName());
        Organ updatedOrgan = organRepository.save(organ);
        LOG.info("Updated organ details. Response :"+updatedOrgan);
        return updatedOrgan;
    }

P.S - I only want to use the Java 8 method and not conventional approach.

Thanks in advance!

Answer 1

Make it a lambda with a body enclosed by curly braces and a return statement instead of an expression lambda:

Organ organ = organRepository.findById(organId)
                .orElseThrow(() -> {
                    LOG.log(Level.SEVERE,"Organ with id "+organId + "not found");
                    return new ResourceNotFoundException("organ", "id", organId);
                });

Answer 2

You have to use return

Organ organ = organRepository.findById(organId)
        .orElseThrow(() -> {
            LOG.log(Level.SEVERE,"Organ with id "+organId + "not found");
            return new ResourceNotFoundException("organ", "id", organId);
        });