Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Is this a compiler bug or it's my code?

Here is a sample code:

#include <iostream>
#include <stdexcept>
#include <cstring>
#include <ctime>
#include <sstream>

using std::cout;
using std::endl;

std::size_t const BUF_SIZE(1000);

std::ostream& operator<<(std::ostream& os, std::tm const& rhs)
{   
    os << asctime(&rhs);
    return os; 
}   

std::istream& operator>>(std::istream& is, std::tm& rhs)
{   
    while (is.peek() == ' ' || is.peek() == '\t')
    {   
        is.get();
    }   
    std::streampos curPos = is.tellg();
    char buf[BUF_SIZE];
    is.getline(buf, BUF_SIZE);
    char* ptr = strptime(buf, "%D %T", &rhs);
    if (ptr == 0)
    {   
        throw std::runtime_error("strptime() failed!");
    }   
    std::size_t processed = ptr - buf;
    is.seekg(curPos + static_cast<std::streampos>(processed));
    return is; 
}   

int main()
{   
    std::istringstream is("10101 07/09/12 07:30:00 123.24");
    int uuid(0);
    double price(0);
    std::tm ptime; std::memset(&ptime, 0, sizeof(tm));

    is >> uuid >> ptime >> price;
    cout << "UUID: " << uuid << endl;
    cout << "Time: " << ptime;
    cout << "Price: " << price << endl;
} 

where I'm trying to overload the << and >> operators for struct tm! If I compile my code with g++ and run it, I get:

UUID: 10101
Time: Sun Jul  9 07:30:00 2012
Price: 123.24

Perfect!

But, if I compile it using clang++, I get:

UUID: 10101
Time: Sun Jul  9 07:30:00 2012
Price: 0

OOPS!

What is going on? it this an issue with clang or it's the way i'm processing the istream?

like image 676
Reza Toghraee Avatar asked Jun 12 '12 01:06

Reza Toghraee


1 Answers

I was able to reproduce this (g++ 4.7.0 and clang++ 3.1 with libc++-svn) and a brief debugging session showed that clang++ sets the eofbit after getline (which is normal), which then somehow causes seekg to set failbit. This sounds like a bug, given that seekg first clears eofbit (§27.7.2.3/41)

To work around, insert is.clear() anywhere between the getline and the seekg.

like image 100
Cubbi Avatar answered Sep 30 '22 15:09

Cubbi