Is there a better way to write this "if" boolean evaluation?

Question

I have this small snippet of python code that I wrote. It works, but I think there should be a more streamlined method to achieve the same results. I'm just not seeing it. Any ideas?

if tx_avt >= 100: tx = 1 
elif tx_avt < 100 and tx_avt >= 50: tx = 2 
elif tx_avt < 50 and tx_avt >= 25: tx = 3
elif tx_avt < 25 and tx_avt >= 12.5: tx = 4 
else: tx = 5

Answer 1

You can change it to:

if tx_avt >= 100: tx = 1 
elif tx_avt >= 50: tx = 2 
elif tx_avt >= 25: tx = 3
elif tx_avt >= 12.5: tx = 4 
else: tx = 5

Explanation:

• If if tx_avt >= 100 is not true, then you can deduce that tx_avt < 100 must be true.
• This eliminates the need to do the "tx_avt < 100" part in the check "elif tx_avt < 100 and tx_avt >= 50:".

The same logic cascades down & applies to the rest of the elif cases.

---

Related reading: Why Python Doesn't Have a Switch Statement, and its Alternatives.

Answer 2

you dont need the upper bounds on the elifs since these are resolved by the clause above them ...

elif tx_avt >= 50 : #do something
elif tx_avt >= 25 : #somthing else

on a side note in python you can do

if 3 < ab < 10 : #check if ab is between 3 and 10