Is it better practice to use String.format over string Concatenation in Java?

Question

Is there a perceptible difference between using String.format and String concatenation in Java?

I tend to use String.format but occasionally will slip and use a concatenation. I was wondering if one was better than the other.

The way I see it, String.format gives you more power in "formatting" the string; and concatenation means you don't have to worry about accidentally putting in an extra %s or missing one out.

String.format is also shorter.

Which one is more readable depends on how your head works.

Answer 1

I'd suggest that it is better practice to use String.format(). The main reason is that String.format() can be more easily localised with text loaded from resource files whereas concatenation can't be localised without producing a new executable with different code for each language.

If you plan on your app being localisable you should also get into the habit of specifying argument positions for your format tokens as well:

"Hello %1$s the time is %2$t" 

This can then be localised and have the name and time tokens swapped without requiring a recompile of the executable to account for the different ordering. With argument positions you can also re-use the same argument without passing it into the function twice:

String.format("Hello %1$s, your name is %1$s and the time is %2$t", name, time) 

Answer 2

About performance:

public static void main(String[] args) throws Exception {         long start = System.currentTimeMillis();   for(int i = 0; i < 1000000; i++){     String s = "Hi " + i + "; Hi to you " + i*2;   }   long end = System.currentTimeMillis();   System.out.println("Concatenation = " + ((end - start)) + " millisecond") ;    start = System.currentTimeMillis();   for(int i = 0; i < 1000000; i++){     String s = String.format("Hi %s; Hi to you %s",i, + i*2);   }   end = System.currentTimeMillis();   System.out.println("Format = " + ((end - start)) + " millisecond"); } 

The timing results are as follows:

• Concatenation = 265 millisecond
• Format = 4141 millisecond

Therefore, concatenation is much faster than String.format.