Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

InsertAllOnSubmit only inserts first data record

I noticed a strange behaviour in my Import Service today when I tried to import multiple data records.

When I do it like this, all data records are imported and the auto-incremented value is correct (see screenshot):

public void Create(List<Property> properties)
{
    foreach (Property prop in properties) {
        dbc.Property.InsertOnSubmit(prop);
        dbc.SubmitChanges();
    }
}

When I try it like this, only the first data record get's a correct auto-incremented value (see screenshot):

foreach (Property prop in properties) {
    dbc.Property.InsertOnSubmit(prop);
}
dbc.SubmitChanges();

Same here:

dbc.Property.InsertAllOnSubmit(properties);
dbc.SubmitChanges();

Does anybody have an idea why it's like that? All three variants should import all data records according to my understanding, but the missing auto-incremented values indicate it's not that way.

[EDIT] Added two screenshots.

like image 941
Michael Klement Avatar asked Jul 02 '09 14:07

Michael Klement


2 Answers

I had the same problem and it turned out the issue was due to overriding Equals on the mapped class. My Equals method was only comparing the primary key field which was an identity field. Of course when the objects are new, all identities are 0. So when InsertAllOnSubmit was called, it thought that all new objects were the same and basically ignored every one but the first.

like image 159
Nicholas Roeder Avatar answered Nov 02 '22 18:11

Nicholas Roeder


Not quite sure why the 2nd variation doesn't work, however, shouldn't the last one be:

dbc.Property.InsertallOnSubmit(properties);
dbc.SubmitChanges();

Edit

For the second loop try:

foreach (Property prop in properties) 
{   
    var newProp = new Property();
    newProp = prop;
    dbc.Property.InsertOnSubmit(newProp);
}
dbc.SubmitChanges();

For the last solution try:

dbc.Property.InsertAllOnSubmit(properties.ToList());
dbc.SubmitChanges();
like image 28
James Avatar answered Nov 02 '22 19:11

James