Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Image is getting added automatically in UItableView Cell?

Helo all,

I am having a very strange situation here.I have a table view in which i have custom cells. So i have designed my own custom cell.In custom cell i am displaying the image as well text.The data of table comes from server.If any image in json then image will be displayed else only text is displayed.So cell will dynamic.I have used bezier path to wrap text around image.No if image is there so text will be wrapped.When i add new post from server with image & i refresh the table then it automatically display the image for other post as well.It will display the same image which is same image for last.I don;t know why new cell is adding image in it's cell even the code works fine i have dbugged it using breakpoints.Please tell what could be the issue.

Here is code for cellForRowAtIndexPath

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
{
    //define variables here
    static NSString *CellIdentifier = @"homeCell";
    HomeCell *cell = [tableView
                      dequeueReusableCellWithIdentifier:CellIdentifier
                      forIndexPath:indexPath];
    [cell setSelectionStyle:UITableViewCellSelectionStyleNone];
    if([arr_post count]>0)
    {
        NSMutableAttributedString *mutableAttributeStr;
        NSAttributedString *attributeStr;

        [cell layoutIfNeeded];
        //get the post data
        Post *user_post=[arr_post objectAtIndex:indexPath.row];

        //set the button tags
        cell.btn_like.tag=indexPath.row;
        cell.btn_comment.tag=indexPath.row;
        cell.btn_fav.tag=indexPath.row;
        cell.btn_con.tag=indexPath.row;
        cell.btn_book.tag=indexPath.row;

        //add info to buttons
        cell.btn_like.selected=user_post.isPostLiked;
        cell.btn_comment.selected=user_post.isPostCommented;
        cell.btn_fav.selected=user_post.isPostFavourite;
        cell.btn_con.selected=user_post.isPostCondolence;
        cell.btn_book.selected=user_post.isPostBookmarked;

        //add user info
        cell.label_name.text=user_post.username;
        cell.img_profile.layer.cornerRadius = 25;
        cell.img_profile.clipsToBounds = YES;
        [cell.img_profile setImageWithURL:[NSURL URLWithString:[IMAGE_BASE_URL stringByAppendingString:user_post.user_profileImage]]placeholderImage:[UIImage imageNamed:@"post_placeholder.png"]];
        //add location
        if([user_post.location isEqualToString:@"Not Available"])
        {
            [cell.img_icon_location setHidden:true];
            [cell.label_location setHidden:true];
        }
        else
        {
            [cell.img_icon_location setHidden:false];
            [cell.label_location setHidden:false];
            cell.label_location.text=user_post.location;
        }
        //ad post info
        cell.tv_post.text=user_post.post_description;
        cell.tv_post.font = [UIFont fontWithName:user_post.font_family size:[user_post.font_size floatValue]];
        [cell.tv_post setTextColor:[self colorFromHexString:user_post.font_color]];

        NSDateFormatter *formatter = [[NSDateFormatter alloc] init];
        [formatter setDateFormat:@"yyyy-MM-dd HH:mm:ss"];
        NSDate *date = [formatter dateFromString:user_post.modification_date];
        NSLog(@"user post image is %@",user_post.post_image);

        if([user_post.post_image isEqualToString:@"none"] && [user_post.post_video isEqualToString:@"none"])
        {

            NSLog(@"NOT INSIDE THE CONDITION");

        }
        else
        {
            NSLog(@"INSIDE BEIZER PATH CONDITION");
            UIBezierPath * imgRect = [UIBezierPath bezierPathWithRect:CGRectMake(0, 10, 100, 100)];
            cell.tv_post.textContainer.exclusionPaths = @[imgRect];
            UIImageView *tv_image =[[UIImageView alloc]initWithFrame:CGRectMake(0, 10, 100, 100)];

            if(![user_post.post_image isEqualToString:@"none"])
            {
                [tv_image setImageWithURL:[NSURL URLWithString:[IMAGE_BASE_URL stringByAppendingString:user_post.post_image]]placeholderImage:[UIImage imageNamed:@"post_placeholder.png"]];

            }
            if(![user_post.post_video isEqualToString:@"none"])
            {
                [tv_image setImageWithURL:[NSURL URLWithString:[IMAGE_BASE_URL stringByAppendingString:user_post.post_video_thumbnail]]placeholderImage:[UIImage imageNamed:@"post_placeholder.png"]];

            }

            [cell.tv_post addSubview:tv_image];
        }
        //make textview height dynamic
        cell.tv_post.scrollEnabled=NO;
        if([user_post.post_image isEqualToString:@"none"] && [user_post.post_video isEqualToString:@"none"])
        {
            CGFloat fixedWidth = cell.tv_post.frame.size.width;
            CGSize newSize = [cell.tv_post sizeThatFits:CGSizeMake(fixedWidth, MAXFLOAT)];
            CGRect newFrame = cell.tv_post.frame;
            newFrame.size = CGSizeMake(fmaxf(newSize.width, fixedWidth), newSize.height);
            cell.tv_post.frame = newFrame;
            cell.tv_height.constant=cell.tv_post.frame.size.height;
            [cell.view_tvContainer layoutIfNeeded];
        }
               //set the border of uiview
        cell.view_tvContainer.layer.borderColor = [UIColor blackColor].CGColor;
        cell.view_tvContainer.layer.borderWidth = 2.0f;

        //set the like count
        NSString *first_like_user=recent_like_name=user_post.recent_like_name;
        NSLog(@"FIRST LIEK USER IS %@",first_like_user);
        NSString *str_recent_like_name;
        int count=(int)[first_like_user length];
        int like_count=[user_post.like_count intValue];
        if(like_count>0)
        {
            cell.label_like_count.lineBreakMode=NSLineBreakByWordWrapping;
            [cell.label_like_count sizeToFit];
            [cell.label_like_count setHidden:false];
            NSString *str_like_count=[NSString stringWithFormat:@"%lu",(unsigned long)like_count-1];
            if(like_count==1)
            {
                if([myUsername isEqualToString:first_like_user])
                {
                    first_like_user=@"You like this post ";
                    count=3;
                }
                else
                {
                    first_like_user=[first_like_user stringByAppendingString:@" like this post"];
                }
            }
            else if(like_count==2)
            {
                if([first_like_user isEqualToString:myUsername])
                {
                    first_like_user=@"You";
                }
                Post *temp_user_post=[copy_arr_user_post objectAtIndex:indexPath.row];
                first_like_user=[first_like_user stringByAppendingString:@" and "];
                if(temp_user_post.recent_like_name==nil)
                {
                    temp_user_post.recent_like_name=@"";
                }
                str_recent_like_name=[temp_user_post.recent_like_name_two stringByAppendingString:@" like this post"];
                first_like_user=[first_like_user stringByAppendingString:str_recent_like_name];
            }
            else
            {
                if(like_count>1000)
                {
                    like_count=like_count/1000;
                    str_like_count=[NSString stringWithFormat:@"%lu",(unsigned long)like_count];
                    str_like_count=[str_like_count stringByAppendingString:@"k"];
                    first_like_user=[first_like_user stringByAppendingString:@" and "];
                    str_like_count=[str_like_count stringByAppendingString:@" others like this post"];
                    first_like_user=[first_like_user stringByAppendingString:str_like_count];
                }
                else
                {
                    if([first_like_user isEqualToString:myUsername])
                    {
                        first_like_user=@"You";
                    }
                    first_like_user=[first_like_user stringByAppendingString:@" and "];
                    str_like_count=[str_like_count stringByAppendingString:@" others like this post"];
                    first_like_user=[first_like_user stringByAppendingString:str_like_count];
                }
            }
            mutableAttributeStr = [[NSMutableAttributedString alloc]initWithString:first_like_user];
            attributeStr = [[NSAttributedString alloc]initWithString:@"\n" attributes:@{NSFontAttributeName : [UIFont fontWithName:@"HelveticaNeue-Bold" size:8]}];

            [mutableAttributeStr addAttribute:NSFontAttributeName value: [UIFont fontWithName:@"Helvetica-Bold" size:14.0]  range:NSMakeRange(0, count)];
            [mutableAttributeStr addAttribute:NSForegroundColorAttributeName value:[self colorFromHexString:@"#48a0dd"] range:NSMakeRange(0, count)];

            [mutableAttributeStr appendAttributedString:attributeStr];

            [cell.label_like_count setAttributedText:mutableAttributeStr];
        }
        else
        {
            [cell.label_like_count setHidden:true];


        }
        // show dynamic comment
        NSMutableArray *user_comments=user_post.comments;
        float comment_count=[user_post.comment_count intValue];
         NSLog(@"ID IS %@",user_post.id);
        if(comment_count>0)
        {
            //make label multiline
            cell.first_comment.lineBreakMode=NSLineBreakByWordWrapping;
            [cell.first_comment sizeToFit];
            cell.second_cmment.lineBreakMode=NSLineBreakByWordWrapping;
            [cell.second_cmment sizeToFit];
            cell.third_comment.lineBreakMode=NSLineBreakByWordWrapping;
            [cell.third_comment sizeToFit];

            if(comment_count==1)
            {
                [cell.first_comment setHidden:false];
                [cell.second_cmment setHidden:true];
                [cell.third_comment setHidden:true];

            }
            else if(comment_count==2)
            {
                [cell.first_comment setHidden:false];
                [cell.second_cmment setHidden:false];
                [cell.third_comment setHidden:true];

            }
            else
            {
                [cell.first_comment setHidden:false];
                [cell.second_cmment setHidden:false];
                [cell.third_comment setHidden:false];
                [cell.btn_more_comments setHidden:false];

            }
            for(l=0;l<[user_comments count];l++)
            {
                Comment *comment=[user_comments objectAtIndex:l];
                NSString *comment_string=[comment.user_name stringByAppendingString:@" "];
                comment_string=[comment_string stringByAppendingString:comment.comment];
                int count=(int)[comment.user_name length];
                NSMutableAttributedString* mutableAttributeStr = [[NSMutableAttributedString alloc]initWithString:comment_string];
                NSAttributedString *attributeStr = [[NSAttributedString alloc]initWithString:@"\n" attributes:@{NSFontAttributeName : [UIFont fontWithName:@"HelveticaNeue-Bold" size:8]}];

                [mutableAttributeStr addAttribute:NSFontAttributeName value: [UIFont fontWithName:@"Helvetica-Bold" size:14.0]  range:NSMakeRange(0, count)];
                [mutableAttributeStr addAttribute:NSForegroundColorAttributeName value:[self colorFromHexString:@"#48a0dd"] range:NSMakeRange(0, count)];

                [mutableAttributeStr appendAttributedString:attributeStr];
                // end of the repetitive pattern
                if (l == 0)
                {
                    [cell.first_comment setAttributedText:mutableAttributeStr];
                }
                else if (l == 1)
                {
                    [cell.second_cmment setAttributedText:mutableAttributeStr];
                }
                else if (l == 2)
                {
                    [cell.third_comment setAttributedText:mutableAttributeStr];
                }
            }
        }
        else
        {
            [cell.first_comment setHidden:true];
            [cell.second_cmment setHidden:true];
            [cell.third_comment setHidden:true];
            [cell.btn_more_comments removeFromSuperview];
        }
        cell.label_time.text=[BaseController timeAgoStringFromDate:date];
        [arr_indexpath addObject:indexPath];

    }

    return cell;
}
like image 215
TechChain Avatar asked Oct 24 '15 05:10

TechChain


1 Answers

Keep in mind that the cells is reused. If you have, say, 10000 rows in your table datasource, the table view won't create that many rows. It will only create enough rows to be displayed on the screen and a few others to be preloaded.
For every time you scroll your table, the tableview will use those cells that go invisible to load the new cells that just become visible, to make a illusion of infinite amount of rows. That why those new cells have the old data. So basically, you will have to set your UIImageView's image to nil in cellForRowAtIndexpath: if no image is available.

if([user_post.post_image isEqualToString:@"none"] && [user_post.post_video isEqualToString:@"none"])
        {

            NSLog(@"NOT INSIDE THE CONDITION");

        }

In the code of you above, you simply print out a log, while what you also have to do is setting the UIImageView's image to nil.

So this is my suggestion:

//if([user_post.post_image isEqualToString:@"none"] && [user_post.post_video isEqualToString:@"none"])
//{

//   NSLog(@"NOT INSIDE THE CONDITION");

//}
//else
{
    NSLog(@"INSIDE BEIZER PATH CONDITION");
    UIBezierPath * imgRect = [UIBezierPath bezierPathWithRect:CGRectMake(0, 10, 100, 100)];
    cell.tv_post.textContainer.exclusionPaths = @[imgRect];
    UIImageView *tv_image =[[UIImageView alloc]initWithFrame:CGRectMake(0, 10, 100, 100)];

    if(![user_post.post_image isEqualToString:@"none"])
    {
        [tv_image setImageWithURL:[NSURL URLWithString:[IMAGE_BASE_URL stringByAppendingString:user_post.post_image]]placeholderImage:[UIImage imageNamed:@"post_placeholder.png"]];

    }
    else{
        [tv_image setImage:nil]; //Prevent the old data to be shown
    }

    if(![user_post.post_video isEqualToString:@"none"])
    {
        [tv_image setImageWithURL:[NSURL URLWithString:[IMAGE_BASE_URL stringByAppendingString:user_post.post_video_thumbnail]]placeholderImage:[UIImage imageNamed:@"post_placeholder.png"]];

    }
    else{
        [tv_image setImage:nil];//Prevent the old data to be shown
    }

    [cell.tv_post addSubview:tv_image];
}

Maybe this code doesn't fit your requirements about how the data will be displayed, but hope it helps you to get the idea!

like image 114
FlySoFast Avatar answered Oct 26 '22 13:10

FlySoFast