How to return the number of a month in C# function

Question

I want to return the number of a month and i made a function but it always returns 0

this is my code:

public int getNrMonth(String s)
    {
        int nr=0;
        if (s.Equals("January"))
            nr = 1
        if (s.Equals("February"))
            nr = 2;
        return nr;


    }

Could someone tell me wath is wrong please? I'm beginner!

Answer 1

Why wouldn't you use the built in function:

DateTime.ParseExact(monthName, "MMMM", CultureInfo.CurrentCulture ).Month

Here is an example on use:

How to parse a month name (string) to an integer for comparison in C#?

Answer 2

It'd be better to do it like this:

switch (s.Trim().ToUpper())
{
    case "JANUARY": return 1;
    case "FEBRUARY": return 2;
    // etc.
}

return 0;

Reasons:

1. switch is optimized to begin with (small point, but worth mentioning).
2. Once you have the value, all the remaining if checks are pointless.
3. Assuming you want "january" and "January" and " January " and "jaNuarY" all to return 1, the Trim() and ToUpper() calls will take care of that.

Answer 3

OK, you're a beginner, but you still have tools at your disposal. Set a breakpoint and step through in the debugger. Take a look at the value of s and nr as you do. Notice which if statements execute the nr = part and which you don't. Then you will understand. As it stands I don't think you pasted your real code in, because your question is missing a semi colon and might not even compile.