According to LiveData documentation:
The LiveData class provides the following advantages:
...
Always up to date data: If a Lifecycle starts again (like an activity going back to started state from the back stack) it receives the latest location data (if it didn’t already).
But sometimes I don't need this feature.
For example, I have following LiveData in ViewModel and Observer in Activity:
//LiveData val showDialogLiveData = MutableLiveData<String>() //Activity viewModel.showMessageLiveData.observe(this, android.arch.lifecycle.Observer { message -> AlertDialog.Builder(this) .setMessage(message) .setPositiveButton("OK") { _, _ -> } .show() })
Now after every rotation old dialog will appear.
Is there a way to clear stored value after it's handled or is it wrong usage of LiveData at all?
MutableLiveData. MutableLiveData is just a class that extends the LiveData type class. MutableLiveData is commonly used since it provides the postValue() , setValue() methods publicly, something that LiveData class doesn't provide.
SingleLiveEvent:- SingleLiveEvent is a subclass of MutableLiveData with a single Observer Observing it at a time, hence it is aware of view's lifecycle.
You should manually call removeObserver(Observer) to stop observing this LiveData. While LiveData has one of such observers, it will be considered as active. If the observer was already added with an owner to this LiveData, LiveData throws an IllegalArgumentException .
There are actually a few ways to resolve this issue. They are summarized nicely in the article LiveData with SnackBar, Navigation and other events (the SingleLiveEvent case). This is written by a fellow Googler who works with the Architecture Components team.
TL;DR A more robust approach is to use an Event wrapper class, which you can see an example of at the bottom of the article.
This pattern has made it's way into numerous Android samples, for example:
Why is an Event wrapper preferred over SingleLiveEvent?
One issue with SingleLiveEvent is that if there are multiple observers to a SingleLiveEvent, only one of them will be notified when that data has changed - this can introduce subtle bugs and is hard to work around.
Using an Event wrapper class, all of your observers will be notified as normal. You can then choose to either explicitly "handle" the content (content is only "handled" once) or peek at the content, which always returns whatever the latest "content" was. In the dialog example, this means you can always see what the last message was with peek
, but ensure that for every new message, the dialog only is triggered once, using getContentIfNotHandled
.
Alex's response in the comments is I think exactly what you're looking for. There's sample code for a class called SingleLiveEvent. The purpose of this class is described as:
A lifecycle-aware observable that sends only new updates after subscription, used for events like navigation and Snackbar messages.
This avoids a common problem with events: on configuration change (like rotation) an update can be emitted if the observer is active. This LiveData only calls the observable if there's an explicit call to setValue() or call().
I`m not sure if it will work in your case, but in my case (increasing/decreasing items amount in Room by click on views) removing Observer and checking if there is active observers let me do the job:
LiveData<MenuItem> menuitem = mViewModel.getMenuItemById(menuid); menuitem.observe(this, (MenuItem menuItemRoom) ->{ menuitem.removeObservers(this); if(menuitem.hasObservers())return; // Do your single job here }); });
UPDATE 20/03/2019:
Now i prefer this: EventWraper class from Google Samples inside MutableLiveData
/** * Used as a wrapper for data that is exposed via a LiveData that represents an event. */ public class Event<T> { private T mContent; private boolean hasBeenHandled = false; public Event( T content) { if (content == null) { throw new IllegalArgumentException("null values in Event are not allowed."); } mContent = content; } @Nullable public T getContentIfNotHandled() { if (hasBeenHandled) { return null; } else { hasBeenHandled = true; return mContent; } } public boolean hasBeenHandled() { return hasBeenHandled; } }
In ViewModel :
/** expose Save LiveData Event */ public void newSaveEvent() { saveEvent.setValue(new Event<>(true)); } private final MutableLiveData<Event<Boolean>> saveEvent = new MutableLiveData<>(); LiveData<Event<Boolean>> onSaveEvent() { return saveEvent; }
In Activity/Fragment
mViewModel .onSaveEvent() .observe( getViewLifecycleOwner(), booleanEvent -> { if (booleanEvent != null) final Boolean shouldSave = booleanEvent.getContentIfNotHandled(); if (shouldSave != null && shouldSave) saveData(); } });
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With