Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How to check multiple objects for nullity?

Often, I can see a code constructs like following:

if(a == null || b == null || c == null){     //... } 

I wonder if there is any widely used library (Google, Apache, etc.) to check against nullity for multiple objects at once, e.g.:

if(anyIsNull(a, b, c)){     //... } 

or

if(allAreNulls(a, b, c)){     //... } 

UPDATE:

  1. I perfectly know how to write it by myself
  2. I know it can be the result of the poor program structure but it's not a case here
  3. Let's make it more challenging and replace original example with something like this:

    if(a != null && a.getFoo() != null && a.getFoo().getBar() != null){     //... } 

UPDATE 2:

I've created a pull request for Apache Commons Lang library to fix this gap:

  • Issue: https://issues.apache.org/jira/browse/LANG-781
  • PR: https://github.com/apache/commons-lang/pull/108

These will be incorporated in commons-lang, version 3.5:

  • anyNotNull (Object... values)
  • allNotNull (Object... values)
like image 864
Krzysztof Wolny Avatar asked Jul 23 '15 08:07

Krzysztof Wolny


People also ask

How do you check if an object is null?

Typically, you'll check for null using the triple equality operator ( === or !== ), also known as the strict equality operator, to be sure that the value in question is definitely not null: object !== null . That code checks that the variable object does not have the value null .

Why is checking for null a good practice?

It is a good idea to check for null explicitly because: You can catch the error earlier. You can provide a more descriptive error message.


2 Answers

In Java 8, you could use Stream.allMatch to check whether all of the values match a certain condition, such as being null. Not much shorter, but maybe a bit easier to read.

if (Stream.of(a, b, c).allMatch(x -> x == null)) {     ... } 

And analogeously for anyMatch and noneMatch.


About your "more challenging example": In this case, I think there is no way around writing a lazy-evaluated conjunction of null-checks, like the one you have:

if (a != null && a.getFoo() != null && a.getFoo().getBar() != null) {     ... } 

Any of the other approaches, using streams, lists, or var-arg methods, would try to evaluate a.getFoo() before a has been tested not to be null. You could use Optional with map and method pointers, that will be lazily evaluated one after the other, but whether this makes it any more readable is debatable and may vary from case to case (particularly for longer class names):

if (Optional.ofNullable(a).map(A::getFoo).map(B::getBar).isPresent()) {     ... }  Bar bar = Optional.ofNullable(a).map(A::getFoo).map(B::getBar).orElse(null); 

Another alternative might be to try to access the innermost item, but I have a feeling that this is not considered good practice, either:

try {     Bar bar = a.getFoo().getBar();     ... catch (NullPointerException e) {     ... } 

Particularly, this will also catch any other NPEs after accessing that element -- either that, or you have to put only the Bar bar = ... in the try and everything else in another if block after the try, nullifying any (questionable) gains in readability or brevity.


Some languages have a Safe Navigation Operator, but it seems like Java is not one of them. This way, you could use a notation like a?.getFoo()?.getBar() != null, where a?.getFoo() will just evaluate to null if a is null. You could emulate behavior like this with a custom function and a lambda, though, returning an Optional or just a value or null if you prefer:

public static <T> Optional<T> tryGet(Supplier<T> f) {     try {         return Optional.of(f.get());     } catch (NullPointerException e) {         return Optional.empty();     } }  Optional<Bar> bar = tryGet(() -> a.getFoo().getBar();); 
like image 76
tobias_k Avatar answered Sep 19 '22 22:09

tobias_k


EDIT 2018: As of Apache Commons lang 3.5, there has been ObjectUtils.allNotNull() and ObjectUtils.anyNotNull().


No.

None of Apache Commons Lang (3.4), Google Guava (18) and Spring (4.1.7) provide such a utility method.

You'll need to write it on your own if you really, really need it. In modern Java code, I'd probably consider need for such a construct a code smell, though.

like image 31
Petr Janeček Avatar answered Sep 19 '22 22:09

Petr Janeček