Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How do you make Inno Setup not look frozen while performing a long Exec?

The long Exec is installing .NET 3.5, and out script is based off this one: http://www.blackhillsoftware.com/blog/2006/06/26/using-innosetup-with-the-dotnet-framework/

The problem is that it's using ewWaitUntilTerminated because we need to capture the exit code. It's made a little worse by the fact that we're running it /passive /norestart so that it's less work on the user's part (Maybe we shouldn't?)

The easiest option I could think of is to hide the window while it's installing .NET and showing it again after it's done, but I'm not sure how to do that.

The ideal solution would be to show a progress page, but it doesn't seem like it'd be possible since we'd need to return right away but somehow still be notified when the process exits and capture the exit code otherwise we'd just have an eternal progress bar.

Any ideas on how to go about this?

Edit: Minimizing would probably be better, but not sure how to do that either. We do display a message informing the user that the process may take 10-20 minutes, however the problem is that the main setup form is completely frozen, can't move, minimize or do anything with it. Also running /passive the .NET installer doesn't actually show any progress for a good minute or two on a slower machine.

like image 688
Davy8 Avatar asked Feb 26 '09 18:02

Davy8


2 Answers

One way of making Inno Setup "not look frozen" is to add a "fake" progress indicator, like a marquee, to show that something is going on. But this won't solve the "window not dragable / moveable" problem.

So, another way is to really unfreeze the Inno Setup GUI, while a long running process is executed: The "long running process" is executed via ShellExecuteEx(). Then the installer uses a while loop with the condition WaitForSingleObject and a very minimal timeout to execute AppProcessMessage.

AppProcessMessage is itself a helper function. It uses "generic" code to recreate a Application.ProcessMessages-ish procedure, using the WinAPI function PeekMessage(), TranslateMessage() and DispatchMessage(). Its job is to be the message pump to the Inno Setup GUI.

This trick makes the window responsive/draggable again, while the "long running process" is processed in the background.

This is the source for the execution loop:

if ShellExecuteEx(ExecInfo) then
begin
  while WaitForSingleObject(ExecInfo.hProcess, 100) = WAIT_TIMEOUT
  do begin
      AppProcessMessage;
      WizardForm.Refresh();
  end;
  CloseHandle(ExecInfo.hProcess);
end;

The following GIST for unzip.iss contains the code for a standalone Unzip Helper for executing 7zip without blocking the Inno Setup GUI, including the bits and pieces for working with the AppProcessMessage function.

In this case "unzip" is just an example and you might replace the executed application with whatever, a .NET installer or any other long running task.

like image 101
Jens A. Koch Avatar answered Sep 18 '22 16:09

Jens A. Koch


Although it probably would be easy, I don't recommend hiding your installer while the .Net installer runs. I've seen other installers do that, and when it happens, I think the installation is finished, and then I'm confused when I find that it's really not. (And when the installation really is finished, I can't be sure of that, either. Maybe it just hid itself again.)

You can display custom pages in the Inno Setup wizard. Making such a page show a progress bar and keeping it accurate would probably be a challenge, but at least you could display a message on the wizard page saying that your installer is waiting for the .Net installer before proceeding. See the "Using Custom Wizard Pages" section of the help file.

like image 40
Rob Kennedy Avatar answered Sep 19 '22 16:09

Rob Kennedy