Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How do i use Application_Error in ASP.NET MVC?

I want to use Application_Error with my MVC project, but i can't get it to work. I add the following to my Global.asax file:

    protected void Application_Error(object sender, EventArgs e)
    {
        Exception objErr = Server.GetLastError().GetBaseException();
        Session["Test"] = "Message:" + objErr.Message.ToString();
    }

(The Session is only for tests. Im gonna use a database to log error, if i get this to work.) Then i try to throw an exception from my HomeController and my Home/Index View, but it only triggers Debug.

    public ActionResult Index()
    {
        ViewData["Message"] = "Welcome to ASP.NET MVC!";
        throw (new Exception());
        return View();
    }

In my Webconfig file i set a defaulterror page but it doesn't redirect to the view:

    <customErrors defaultRedirect="Home/Error">
        <error statusCode="403" redirect="NoAccess.htm" />
        <error statusCode="404" redirect="FileNotFound.htm" />
    </customErrors>
like image 375
Poku Avatar asked Sep 23 '09 07:09

Poku


People also ask

How does MVC handle application error in global ASAX?

Setting HandleError Attribute as a Global Filter Any unhandled exception that takes place within the boundary of the MVC application will now be handled by this global error handler. To test this global handler, comment out the [HandleError] attribute from the action or the controller and then run the application.


1 Answers

So firstly remember that global error handling should be a last resort, and controller classes have a specific error method for errors;

protected virtual bool OnError(string actionName, 
    System.Reflection.MethodInfo methodInfo, Exception exception)

Within this you can redirect to the standard shared error view;

protected override bool OnError(string actionName, 
    System.Reflection.MethodInfo methodInfo, Exception exception)
{
   RenderView("Error", exception);
   return false;
}

The problem you have in the global application error is that it has no concept of views or controllers, so if you want to redirect in there then you must use a known URL

protected void Application_Error(object sender, EventArgs e)
{
    Exception exception = Server.GetLastError();
    System.Diagnostics.Debug.WriteLine(exception);
    Response.Redirect("/Home/Error");
}

but you don't need to do this. If you set the default error page in web.config then you don't need that redirect

<customErrors defaultRedirect="Home/Error" />

However, unless you've added an error view to your Home controller that doesn't exist, so add the following to the home controller

public ActionResult Error()
{
    return View();
}

Then (if you're sensible) you'd put the error handling code in the Error() method, as that's where all unhandled errors will end up.

public ActionResult Error()
{
    Exception exception = Server.GetLastError();
    System.Diagnostics.Debug.WriteLine(exception);
    return View();
}

And finally remember that by default you don't see custom errors if you are connecting to localhost! So you need to change that behaviour

<customErrors mode="On" defaultRedirect="/Home/Error" />
like image 163
blowdart Avatar answered Oct 05 '22 21:10

blowdart