How do I pass a wildcard parameter to a bash file

Question

I'm trying to write a bash script that allows the user to pass a directory path using wildcards.

For example,

bash show_files.sh * 

when executed within this directory

drw-r--r--  2 root root  4.0K Sep 18 11:33 dir_a -rw-r--r--  1 root root   223 Sep 18 11:33 file_b.txt -rw-rw-r--  1 root root   106 Oct 18 15:48 file_c.sql 

would output:

dir_a file_b.txt file_c.sql 

The way it is right now, it outputs:

dir_a 

contents of show_files.sh:

#!/bin/bash  dirs="$1"  for dir in $dirs do     echo $dir done 

Answer 1

The parent shell, the one invoking bash show_files.sh *, expands the * for you.

In your script, you need to use:

for dir in "$@" do     echo "$dir" done 

The double quotes ensure that multiple spaces etc in file names are handled correctly.

See also How to iterate over arguments in a bash shell script.

---

Potentially confusing addendum

If you're truly sure you want to get the script to expand the *, you have to make sure that * is passed to the script (enclosed in quotes, as in the other answers), and then make sure it is expanded at the right point in the processing (which is not trivial). At that point, I'd use an array.

names=( $@ ) for file in "${names[@]}" do     echo "$file" done 

I don't often use $@ without the double quotes, but this is one time when it is more or less the correct thing to do. The tricky part is that it won't handle wild cards with spaces in very well.

Consider:

$ > "double  space.c" $ > "double  space.h" $ echo double\ \ space.? double  space.c double  space.h $ 

That works fine. But try passing that as a wild-card to the script and ... well, let's just say it gets to be tricky at that point.

If you want to extract $2 separately, then you can use:

names=( $1 ) for file in "${names[@]}" do     echo "$file" done # ... use $2 ... 

Answer 2

Quote the wild-card:

bash show_files.sh '*' 

or make your script accept a list of arguments, not just one:

for dir in "$@" do     echo "$dir" done 

It's better to iterate directly over "$@' rather than assigning it to another variable, in order to preserve its special ability to hold elements that themselves contain whitespace.