Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How do I move values out of an array one at a time?

Tags:

arrays

rust

move

I have ownership of an array of size 3 and I would like to iterate on it, moving the elements out as I go. Basically, I would like to have IntoIterator implemented for a fixed-sized array.

Since arrays don't implement this trait in the standard library (I understand why), is there a workaround to get the desired effect? My objects are not Copy nor Clone. I'd be okay creating a Vec from the array and then iterating into the Vec, but I'm not even sure how to do that.

(For information, I'd like to fulfill an array of Complete)

Here is a simple example of the situation (with a naive iter() attempt):

// No-copy, No-clone struct #[derive(Debug)] struct Foo;  // A method that needs an owned Foo fn bar(foo: Foo) {     println!("{:?}", foo); }  fn main() {     let v: [Foo; 3] = [Foo, Foo, Foo];      for a in v.iter() {         bar(*a);     } } 

playground

Gives

error[E0507]: cannot move out of borrowed content   --> src/main.rs:14:13    | 14 |         bar(*a);    |             ^^ cannot move out of borrowed content 
like image 439
Gyscos Avatar asked Dec 21 '15 23:12

Gyscos


People also ask

How do you move a value in an array?

To change the position of an element in an array:Use the splice() method to insert the element at the new index in the array. The splice method changes the original array by removing or replacing existing elements, or adding new elements at a specific index.

How do I move an array over one?

Create a temp variable and assign the value of the original position to it. Now, assign the value in the new position to original position. Finally, assign the value in the temp to the new position.

How do you move elements in an array to the left?

The array can be left rotated by shifting its elements to a position prior to them which can be accomplished by looping through the array and perform the operation arr[j] = arr[j+1]. The first element of the array will be added to the last of rotated array.


2 Answers

Rust 2021 (available from Rust 1.56)

You can iterate the array with a for loop:

fn main() {     let v: [Foo; 3] = [Foo, Foo, Foo];      for a in v {         bar(a);     } }  struct Foo; fn bar(_: Foo) {} 

Rust 1.51

You can use std::array::IntoIter to get a by-value array iterator:

use std::array::IntoIter;  fn main() {     let v: [Foo; 3] = [Foo, Foo, Foo];      for a in IntoIter::new(v) {         bar(a);     } }  struct Foo; fn bar(_: Foo) {} 

Previous Rust versions

The core thing you would need is some way of getting the value out of the array without moving it.

This can be done using mem::transmute to convert the array to an array of mem::MaybeUninit, then using ptr::read to leave the value in the array but get an owned value back:

let one = unsafe {     let v = mem::transmute::<_, [MaybeUninit<Foo>; 3]>(v);     ptr::read(&v[0]).assume_init() }; bar(one); 

It's just a matter of doing this a few times in a loop and you are good to go.

There's just one tiny problem: you see that unsafe? You guessed it; this is totally, horribly broken in the wider case:

  • MaybeUninit does nothing when it is dropped; this can lead to memory leaks.
  • If a panic happens in the middle of moving the values out (such as somewhere within the bar function), the array will be in a partially-uninitialized state. This is another (subtle) path where the MaybeUninit can be dropped, so now we have to know which values the array still owns and which have been moved out. We are responsible for freeing the values we still own and not the others.
  • Nothing prevents us from accidentally accessing the newly-invalidated values in the array ourselves.

The right solution is to track how many of the values in the array are valid / invalid. When the array is dropped, you can drop the remaining valid items and ignore the invalid ones. It'd also be really nice if we could make this work for arrays of different sizes...

Which is where arrayvec comes in. It doesn't have the exact same implementation (because it's smarter), but it does have the same semantics:

use arrayvec::ArrayVec; // 0.5.2  #[derive(Debug)] struct Foo;  fn bar(foo: Foo) {     println!("{:?}", foo) }  fn main() {     let v = ArrayVec::from([Foo, Foo, Foo]);      for f in v {         bar(f);     } } 
like image 189
Shepmaster Avatar answered Sep 28 '22 04:09

Shepmaster


You may use array of Option<Foo> instead array of Foo. It has some memory penalty of course. Function take() replaces value in array with None.

#[derive(Debug)] struct Foo;  // A method that needs an owned Foo fn bar(foo: Foo) { println!("{:?}", foo); }  fn main() {     let mut v  = [Some(Foo),Some(Foo),Some(Foo)];      for a in &mut v {         a.take().map(|x| bar(x));     } } 
like image 37
aSpex Avatar answered Sep 28 '22 03:09

aSpex