while (div.hasChildNodes()) {
fragment.appendChild(div.firstChild)
}
while (div.firstChild) {
fragment.appendChild(div.firstChild)
}
Comparing the two pieces of pseudo code above, they both append each child of div
to fragment
until there are no more children.
hasChildNodes
or firstChild
they seem identical.hasChildNodes()
exist when I can just coerce firstChild
from null
to false
a) micro-optimization!
b) Although it seems to be common practice, I'm not fond of relying on null/non-null values being used as a substitute for false/true. It's a space saver that's unnecessary with server compression enabled (and can sometimes call subtle bugs). Opt for clarity every time, unless it's demonstrated to be causing bottlenecks.
I'd go for the first option, because it explains your intent perfectly.
There's no functional difference between your two implementations. Both generate the same results in all circumstances.
If you wanted to pursue whether there was a performance difference between the two, you would have to run performance tests on the desired target browsers to see if there was a meaningful difference.
Here's a performance test of the two. It appears to be browser-specific for which one is faster. hasChildNodes()
is significantly faster in Chrome, but firstChild
is a little bit faster in IE9 and Firefox.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With