I've only seen Github from the contributor's perspective, so here's a question for maintainers:
When I make a few changes that are all unrelated (like, improve documentation, fix a Rakefile, test and fix a minor bug), is it easier for maintainers if I bundle them into a single pull request (using, say, a misc-fixes
branch with three unrelated commits), or should I create separate branches with one pull request each?
I'm assuming that as soon as I'm making a major or potentially contentious change, it's better to have a separate pull request for it, so it can be discussed and maintainers don't have to cherry-pick if they want to pull my other changes. But if the changes are minor, what are the arguments for and against bundling several commits into a misc-fixes
branch?
The branch per task is usually reserver for long development efforts, i.e. requiring several commits each one representing an intermediate stable state of the code base.
But for some quick evolutions that doesn't change the stability of the code (it still compile and pass tests), one commit (and then one pull request) is enough.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With