Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Github: separate pull requests for unrelated minor changes?

Tags:

git

github

I've only seen Github from the contributor's perspective, so here's a question for maintainers:

When I make a few changes that are all unrelated (like, improve documentation, fix a Rakefile, test and fix a minor bug), is it easier for maintainers if I bundle them into a single pull request (using, say, a misc-fixes branch with three unrelated commits), or should I create separate branches with one pull request each?

I'm assuming that as soon as I'm making a major or potentially contentious change, it's better to have a separate pull request for it, so it can be discussed and maintainers don't have to cherry-pick if they want to pull my other changes. But if the changes are minor, what are the arguments for and against bundling several commits into a misc-fixes branch?

like image 936
Jo Liss Avatar asked Nov 06 '22 04:11

Jo Liss


1 Answers

The branch per task is usually reserver for long development efforts, i.e. requiring several commits each one representing an intermediate stable state of the code base.

But for some quick evolutions that doesn't change the stability of the code (it still compile and pass tests), one commit (and then one pull request) is enough.

like image 96
VonC Avatar answered Nov 15 '22 05:11

VonC