Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Generic type checking

Is there a way to enforce/limit the types that are passed to primitives? (bool, int, string, etc.)

Now, I know you can limit the generic type parameter to a type or interface implementation via the where clause. However, this doesn't fit the bill for primitives (AFAIK) because they do not all have a common ground (apart from object before someone says! :P).

So, my current thoughts are to just grit my teeth and do a big switch statement and throw an ArgumentException on failure.


EDIT 1:

Just to clarify:

The code definition should be like this:

public class MyClass<GenericType> .... 

And instantiation:

MyClass<bool> = new MyClass<bool>(); // Legal MyClass<string> = new MyClass<string>(); // Legal MyClass<DataSet> = new MyClass<DataSet>(); // Illegal MyClass<RobsFunkyHat> = new MyClass<RobsFunkyHat>(); // Illegal (but looks awesome!) 

EDIT 2

@Jon Limjap - Good point, and something I was already considering. I'm sure there is a generic method that can be used to determine if the type is of a value or reference type.

This could be useful in instantly removing a lot of the objects I don't want to deal with (but then you need to worry about the structs that are used such as Size ). Interesting problem no? :)

Here it is:

where T: struct 

Taken from MSDN.


I'm curious. Could this be done in .NET 3.x using extension methods? Create an interface, and implement the interface in the extension methods (which would probably be cleaner than a bit fat switch). Plus if you then need to later extend to any lightweight custom types, they can also implement the same interface, with no changes required to the base code.

What do you guys think?

The sad news is I am working in Framework 2!! :D


EDIT 3

This was so simple following on from Jon Limjaps Pointer.. So simple I almost want to cry, but it's great because the code works like a charm!

So here is what I did (you'll laugh!):

Code added to the generic class

bool TypeValid() {     // Get the TypeCode from the Primitive Type     TypeCode code = Type.GetTypeCode(typeof(PrimitiveDataType));      // All of the TypeCode Enumeration refer Primitive Types     // with the exception of Object and Empty (Null).     // Since I am willing to allow Null Types (at this time)     // all we need to check for is Object!     switch (code)     {         case TypeCode.Object:             return false;         default:             return true;     } } 

Then a little utility method to check the type and throw an exception,

private void EnforcePrimitiveType() {     if (!TypeValid())         throw new InvalidOperationException(             "Unable to Instantiate SimpleMetadata based on the Generic Type of '" + typeof(PrimitiveDataType).Name +              "' - this Class is Designed to Work with Primitive Data Types Only."); } 

All that then needs to be done is to call EnforcePrimitiveType() in the classes constructors. Job done! :-)

The only downside, it only throws an exception at runtime (obviously) rather than design time. But that's no big deal and could be picked up with utilities like FxCop (which we don't use at work).

Special thanks to Jon Limjap on this one!

like image 961
Rob Cooper Avatar asked Aug 12 '08 15:08

Rob Cooper


People also ask

How do I know the generic type?

Use the IsGenericType property to determine whether the type is generic, and use the IsGenericTypeDefinition property to determine whether the type is a generic type definition. Get an array that contains the generic type arguments, using the GetGenericArguments method.

What is generic type?

A generic type is a generic class or interface that is parameterized over types. The following Box class will be modified to demonstrate the concept.

At what point the generic type checking is done?

Type checking happens at run time and at compile time. The question asked for which occurs ONLY at compile time.

What is a generic type parameter?

Generic Methods A type parameter, also known as a type variable, is an identifier that specifies a generic type name. The type parameters can be used to declare the return type and act as placeholders for the types of the arguments passed to the generic method, which are known as actual type arguments.


2 Answers

public class Class1<GenericType> where GenericType : struct { } 

This one seemed to do the job..

like image 186
Lars Mæhlum Avatar answered Sep 24 '22 20:09

Lars Mæhlum


Primitives appear to be specified in the TypeCode enumeration:

Perhaps there is a way to find out if an object contains the TypeCode enum without having to cast it to an specific object or call GetType() or typeof()?

Update It was right under my nose. The code sample there shows this:

static void WriteObjectInfo(object testObject) {     TypeCode    typeCode = Type.GetTypeCode( testObject.GetType() );      switch( typeCode )     {         case TypeCode.Boolean:             Console.WriteLine("Boolean: {0}", testObject);             break;          case TypeCode.Double:             Console.WriteLine("Double: {0}", testObject);             break;          default:             Console.WriteLine("{0}: {1}", typeCode.ToString(), testObject);             break;         }     } } 

It's still an ugly switch. But it's a good place to start!

like image 38
Jon Limjap Avatar answered Sep 21 '22 20:09

Jon Limjap