Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Fragment's onActivityResult not called after orientation change

Please note, this question is not a duplicate of the following:

  • https://stackoverflow.com/questions/19006776/onactivityresult-not-working-with-fragments
  • onActivityResult not working on fragments

Also, another similar question was asked before, but that doesn't mention orientation changes (and is unresolved).

My onActivityResult method in the Fragment does get called if I don't switch orientation. However, if I follow these steps, it doesn't get called:

  1. Load fragment in FragmentActivity.
  2. From the fragment: startActivityForResult(new Intent(MediaStore.ACTION_IMAGE_CAPTURE), Constants.REQ_CODE_IMAGE_CAPTURE);
  3. Wait for the camera to load.
  4. Switch orientation.
  5. Take picture and click the checkmark.

onActivityResult still gets called in the parent FragmentActivity. However, due to this warning I am getting:

W/FragmentActivity(4418): Activity result no fragment exists for index: 0x22d73

...my guess is that the parent gets destroyed due to the orientation change, and after having been re-created, can't find the Fragment that called startActivityForResult in the first place.

Is this a framework bug? How can this be worked around?

EDIT: Added more code due to popular demand.

FragmentActivity.java:

...

fragment = new ExampleFragment();
FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();
transaction.replace (R.id.mainContentView, fragment);
if (clearBackStack) {
    // clear the back stack
    while (getSupportFragmentManager().popBackStackImmediate ());
    // add the current transaction to the back stack
    transaction.addToBackStack (null);
}
else {
    transaction.addToBackStack(null);
}
transaction.commit();

...

@Override
public void onActivityResult(int reqCode, int resultCode, Intent data) {
    super.onActivityResult(reqCode, resultCode, data);
}

ExampleFragment.java:

Intent takePicture = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
startActivityForResult(takePicture, Constants.REQ_CODE_IMAGE_CAPTURE);

...

@Override
public void onActivityResult(int requestCode, int resultCode, Intent imageReturnedIntent) {
    super.onActivityResult(requestCode, resultCode, imageReturnedIntent);
    switch (requestCode) {
    case Constants.REQ_CODE_IMAGE_CAPTURE:
        // handle added image
    }
}
like image 875
Shade Avatar asked Jan 23 '14 08:01

Shade


2 Answers

Resolved it by moving all of the onActivityResult logic from the Fragment to the Activity.

Do note, however, that the reqCode that gets passed to the Fragment is different than the reqCode that gets delivered to the parent Activity (the one for the Activity is set by the system I think). This meant that I had to also move the original startActivityForResult call from the Fragment to the Activity, and then create a method to call it from the Fragment when needed.

If anyone finds a more elegant way, I would be happy to hear about it.

like image 96
Shade Avatar answered Oct 03 '22 22:10

Shade


i Have one Solution it is currently Working in my project. follow Step.

--> Create Interface name OnActivityResultListener(or name as you wish).

public interface OnActivityResultListener {

public boolean onActivityResultTest(int request_code, int response_code,
        Intent data);

}

--> Make refrence of intercace in your FragmentActivity like

public OnActivityResultListener activityResultListener;

--> now override OnActivityResult in FragmentActivity. like below.

@Override
public void onActivityResult(int arg0, int arg1, Intent arg2) {
    AppLog.Log(TAG, "onActivityResult");
    try {
        if (activityResultListener != null) {
            activityResultListener.onActivityResultTest(arg0,arg1,arg2);
        }
    } catch (Exception e) {
        e.printStackTrace();
    }
    super.onActivityResult(arg0, arg1, arg2);
    }

--> now implement interface in your Fragment and override required method.

@Override
public boolean onActivityResultTest(int requestCode, int resultCode,
        Intent data) {
    AppLog.Log(TAG, "onActivityResultTest");
    if (requestCode == CAMERA_REQUEST && resultCode == Activity.RESULT_OK) {
        isHavePhoto = true;
        bitmap = (Bitmap) data.getExtras().get("data");
        userEditPhoto.setImageBitmap(bitmap);
    }
}

--> and the last step is inside OnAttach Method of Fragment class is register your Fragment in activity for the the Activity result. like

@Override
    public void onAttach(Activity activity) {
        this.activity = (YOUR_FRAGMENT_ACTIVITY) activity;
            this.activity.activityResultListener = this;
        super.onAttach(activity);
    }

-->now test and don't forgot to remove it

@Override
public void onDestroyView() {
    activity.activityResultListener = null;
    super.onDestroyView();
}

->it is some what lengthy process but it is working 100% in any orientation.

like image 28
Imtiyaz Khalani Avatar answered Oct 03 '22 22:10

Imtiyaz Khalani