Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Flex elements ignore percent padding in Firefox

I'm trying to add padding to an element inside a display:flex element. When the padding is defined as a percent, it doesn't display in Firefox, though it does when defined in px. Both cases work as expected in Chrome.

div {      background: #233540;  }  div > div {      color: #80A1B6;  }  .parent {      display: flex;  }  .padded {      padding-bottom: 10%;  }
<div class="parent">      <div class="padded">          asdf      </div>  </div>

Chrome:

chrome

Firefox:

Firefox

Edit: This may be because of Mozilla's decision to interpret vertical percentages with respect to the height of the parent container. Seems crazy to me. https://bugzilla.mozilla.org/show_bug.cgi?id=851379

Edit 2: Yes, it appears that the spec actually defines vertical padding and margin as being resolved against the container's height, so perhaps Chrome is the one not honoring the spec? https://drafts.csswg.org/css-flexbox/#item-margins

like image 923
nvioli Avatar asked Nov 03 '15 15:11

nvioli


People also ask

How do I get rid of margins on flex?

So what you would do is use grid-gap for spacing between the items. Then use padding for the same spacing between the items and the container. The last row margin problem is eliminated. The number of items is no longer a concern.

How do you set the height of a flex item?

Instead of max-height: 250px you should use flex: 0 0 250px and with flex-direction: column it will set height of element to 250px.

How do I change my flex width?

You have to add a wrapper around the right column, and then only specify flex-basis on the . menu element. Now when the menu is hidden, the right column expands the full amount. Great, that works as expected!


2 Answers

See https://lists.w3.org/Archives/Public/www-style/2015Sep/0038.html

Grid/Flex Percentages

  • The group tried to work through how vertical percentage margins and paddings are defined.
    • Note: Top and bottom margins in CSS have traditionally resolved against the containing block width instead of its height, which has some useful effects but is generally surprising. Existing layout modes must of course continue to do so.
    • Previous group resolution had been for option 2 (below), but Google felt they had new information regarding abspos behavior that merited reconsideration.
    • The discussion came down to three potential solutions:
      • Option 1: Always resolve percents against the width.
      • Option 2: Grid and flex resolve against height, and abspos items always resolve against the width.
      • Option 3: Grid and flex, including their abspos items, resolve against the height. Abspos elsewhere continue to resolve against the width.
    • In a straw poll the group was pretty evenly divided between options 1 and 3.
    • Microsoft would object to option 1 and Google to option 3, so the discussion reached an impasse and will be continued privately during the F2F in hopes of reaching a conclusion.

See https://lists.w3.org/Archives/Public/www-style/2015Sep/0113.html,

Flexbox % Follow-Up

  • [...] there was still no conclusion.

The current Flexbox spec warns about this:

Percentage margins and paddings on flex items can be resolved against either:

  • their own axis (left/right percentages resolve against width, top/bottom resolve against height)
  • the inline axis (left/right/top/bottom percentages all resolve against width)

A User Agent must choose one of these two behaviors.

Note: This variance sucks, but it accurately captures the current state of the world (no consensus among implementations, and no consensus within the CSSWG). It is the CSSWG’s intention that browsers will converge on one of the behaviors, at which time the spec will be amended to require that.

Authors should avoid using percentages in paddings or margins on flex items entirely, as they will get different behavior in different browsers.

However, more recently the CSS WG resolved (with some controversy):

Both flexbox and grid items top and bottom margin and padding percent resolves against the available inline direction.

See the updated editor's draft.

like image 176
Oriol Avatar answered Oct 09 '22 03:10

Oriol


For me this does the trick: adding display: table to the div. Don't know if that causes other problems though.

    div {          background: #233540;          display: table;      }      div > div {          color: #80A1B6;      }      .parent {          display: flex;      }      .padded {          padding-bottom: 10%;      }
    <div class="parent">          <div class="padded">              asdf          </div>      </div>
like image 40
Jevado Avatar answered Oct 09 '22 02:10

Jevado