Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Fix potential memory leak in ARC

The following singleton class (SharedManager) helper method might be causing a retain cycle. Getting warnings in static analyzer: "Potential leak of an object allocated at line ..." How can I fix?

I did try making ivar uuid __weak but warning still appears when I analyze.

    NSString  *__weak uuid =  (__bridge NSString *)CFUUIDCreateString(kCFAllocatorDefault, uuidObject);

Thanks

Being called in the class like so:

myUUID = [SharedManager generateUUID];



+ (NSString *)generateUUID
{

 CFUUIDRef uuidObject = CFUUIDCreate(kCFAllocatorDefault);
 NSString  *uuid =  (__bridge NSString *)CFUUIDCreateString(kCFAllocatorDefault, uuidObject);
CFRelease(uuidObject);

  return uuid;

}
like image 957
Slinky Avatar asked Mar 19 '12 21:03

Slinky


2 Answers

Here is a way to release them:

- (NSString *) uuid
{
    CFUUIDRef uuidRef = CFUUIDCreate(NULL);
    CFStringRef uuidStringRef = CFUUIDCreateString(NULL, uuidRef);
    CFRelease(uuidRef);
    NSString *uuid = [NSString stringWithString:(NSString *)
    uuidStringRef];
    CFRelease(uuidStringRef);
    return uuid;
}

Source: http://www.cocoabuilder.com/archive/cocoa/217665-how-to-create-guid.html

like image 83
JOG Avatar answered Oct 19 '22 09:10

JOG


NSString  *uuid =  (__bridge_transfer NSString *)CFUUIDCreateString(kCFAllocatorDefault, uuidObject);

Does that remove the warning?

like image 20
Andy Friese Avatar answered Oct 19 '22 11:10

Andy Friese