'finally block does not complete normally' Eclipse warning

Question

Eclipse give me that warning in the following code:

public int getTicket(int lotteryId, String player) {     try {         c = DriverManager.getConnection("jdbc:mysql://" + this.hostname + ":" + this.port + "/" + this.database, this.user, this.password);          int ticketNumber;          PreparedStatement p = c.prepareStatement(                 "SELECT max(num_ticket) " +                 "FROM loteria_tickets " +                 "WHERE id_loteria = ?"                 );         p.setInt(1, lotteryId);         ResultSet rs = p.executeQuery();         if (rs.next()) {             ticketNumber = rs.getInt(1);         } else {             ticketNumber = -1;         }          ticketNumber++;          p = c.prepareStatement(                 "INSERT INTO loteria_tickets " +                 "VALUES (?,?,?,?)");         p.setInt(1, lotteryId);         p.setInt(2, ticketNumber);         p.setString(3, player);         p.setDate(4, new java.sql.Date((new java.util.Date()).getTime()));         p.executeUpdate();          return ticketNumber;     } catch (Exception e) {         e.printStackTrace();     } finally {          if (c != null) {             try {                 c.close();             } catch (SQLException e) {                 e.printStackTrace();             }         }         return -1;     } } 

What is wrong with my code?

Answer 1

remove return statement from it. Final block is considered to be cleanup block, return is not generally expected in it.

Answer 2

The return from finally "overrides" further exception throwing.

public class App {     public static void main(String[] args) {         System.err.println(f());     }     public static int f() {         try {             throw new RuntimeException();         } finally {             return 1;         }     } } 

1