Enum to integer mapping causing updates on every flush

Question

I am trying to map an enum property (instance of System.DayOfWeek) in my model to an integer database field. Other enum properties in the model should be mapped to strings, so I don't wish to define a convention.

I understand that this should be possible using a fluent mapping like:

Map(x => x.DayOfWeek).CustomType<int>(); 

and indeed, at first glance this appears to be working.

However, I noticed that instances of entities with properties mapped in this way are being updated every time the session was flushed, even though no amendments have been made to them.

To find out what is causing this flush, I set up an IPreUpdateEventListener, and inspected the OldState and State of the entity. See the attached image. In the OldState, the relevant object is an int, whereas in State it is a DayOfWeek.

If I use an HBM XML mapping with no type attribute specified, this issue doesn't arise.

So...

Is this a bug or shortcoming in the GenericEnumMapper? Is there any way of telling the FNH mapping not to specify any type attribute on the generated HBM? If not, can I specify the default type that NH uses for enums (and what is that)?

Answer 1

If you use my enum convention you don't have that problem.

public class EnumConvention : IPropertyConvention, IPropertyConventionAcceptance {     public void Apply(IPropertyInstance instance)     {         instance.CustomType(instance.Property.PropertyType);     }      public void Accept(IAcceptanceCriteria<IPropertyInspector> criteria)     {         criteria.Expect(x => x.Property.PropertyType == typeof(AddressType)  ||             x.Property.PropertyType == typeof(Status) ||             x.Property.PropertyType == typeof(DayOfWeek));     } } 

You can then map your property like regular:

Map(x => x.DayOfWeek); 

EDIT : Updated the convention to pick specific enums to use for the int conversion. All enums that are not checked here would be mapped as string. You might have to experiment a little with what to actually test against. I am unsure if the propertytype will do it directly.