Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Django custom user model and usermanager

i'm building a web application with Django 1.5. I'm using a custom User model with a custom UserManager. I followed the instructions and examples of the official Django documentation.

Now, when i'm trying to create a new user via UserManager.create_user(...) i'm getting a NoneType error: It seems the UserManager's attribute models is of type None. I think i'm setting up the UserManager correctly in the User model ( objects = UserManager() )

I really don't know where i'm making a mistake. Booth my coding partners and i are new to Django. Maybe you can help us out.

Here is the code:

class UserManager(BaseUserManager):
"""
    create a new user

    @param username:  the name for the new user
    @param password:  the password for the new user. if none is provided a random password is generated
    @param person:    the corresponding person object for this user
"""
def create_user(self, username, person, password=None):
    if not username:
        raise ValueError('User must have a valid username')

    user = self.model(username=username, created=datetime.now(), must_change_password=True, deleted=False, person=person)

    user.set_password(password)
    user.save(using=self._db)
    return user

class User(AbstractBaseUser):
    ## the id of the user. unique through the application
    user_id     =   models.AutoField(primary_key=True)
    ## the name of the user. unique through the application
    username    =   models.CharField(max_length=32, unique=True)
    ## the date when the user was created
    created     =   models.DateTimeField()
    ## iff this is true the user must set a new password at next login
    must_change_password    =   models.BooleanField(default=True)
    ## iff true the user is marked as deleted and can not login
    deleted     =   models.BooleanField(default=False)
    ## iff true the user is admin and has all permissions. use with care!
    is_admin = models.BooleanField(default=False)
    ## reference to the person entity that is linked to this specific user
    person      =   models.ForeignKey(Person)
    ## indicates if the user is active or not
    active    =    models.BooleanField(default=True)

    ## define the user manager class for User
    objects     =   UserManager()

    # necessary to use the django authentication framework: this field is used as username
    USERNAME_FIELD  =   'username'

I'm getting the NoneType Error at line user = self.model(..) in the create_user() method in the UserManager

like image 898
7tupel Avatar asked May 17 '13 09:05

7tupel


2 Answers

To create new user you shouldn't call UserManager.create_user(...). Instead you should use :

from django.contrib.auth import get_user_model
get_user_model().objects.create_user(...)

This is how django managers work. You can read docs here

like image 72
Aldarund Avatar answered Sep 17 '22 07:09

Aldarund


I also had problems saving the custom user model and it took me while to figure it our

I think the important line in your code is:

objects     =   UserManager()

within the User class, so in order to save the new user you need to call

new_user=User.objects.create_user(args, args, args, etc)

the "objects" is the item that calls the UserManager class and is called a manager in django

like image 43
colins44 Avatar answered Sep 21 '22 07:09

colins44