Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Did Chrome 40 break justify-content CSS overriding?

I noticed with today's Chrome 40 update that justify-content does not seem to get properly overriden by subsequent style declarations.

See this fiddle for an example:

  <div class="flex-parent">
    <div class="flex-child"></div>
    <div class="flex-child"></div>
  </div>

and

.flex-parent {
  display: flex;
  position: absolute;
  top: 0; right: 0; left: 0;

  /*
     IT SHOULD BE POSSIBLE TO SAFELY REMOVE
     THESE TWO LINES BECAUSE THEY ARE OVERRIDEN:
  */
  background: yellow;
  justify-content: center;
}

.flex-parent {
  /* Overriding background: it works! */
  background: green;

  /* Overriding justify-content: NOPE ;-( */
  justify-content: space-between;
}


.flex-child {
  width: 50px;
  height: 50px;
  margin: 10px;
  background: skyblue;
}

Firefox (override works):

enter image description here

Chrome 40 (override seems to be broken):

enter image description here

Am I correct in my assumptions or do I horribly misunderstand CSS? Note that this doesn't have to do with prefixes: Chrome supports unprefixed justify-content, and if it didn't work, there wouldn't be any difference when commenting out rules in first selector.

Update: filed as https://code.google.com/p/chromium/issues/detail?id=451387

like image 389
Dan Abramov Avatar asked Jan 23 '15 11:01

Dan Abramov


People also ask

What is true about justify-content space evenly?

The items are evenly distributed within the alignment container along the main axis. The spacing between each pair of adjacent items is the same. The empty space before the first and after the last item equals half of the space between each pair of adjacent items.

What does justify-content end do?

The justify-content property aligns the flexible container's items when the items do not use all available space on the main-axis (horizontally). Tip: Use the align-items property to align the items vertically.

What is justify items CSS?

justify-items aligns grid items along the row (inline) axis. Specifically, this property allows you to set alignment for items inside a grid container (not the grid itself) in a specific position (e.g. start , center and end ) or with a behavior (e.g. auto or stretch ).


2 Answers

You are entirely correct in your understanding of the cascade. If you look in the Web Inspector, you'll see the justify-content: center declaration struck out, but only when you uncheck it (in a similar fashion as commenting it out) can you get Chrome to ignore it.

Perhaps they accidentally broke something in a change between Chrome 39 and 40, as they have a really irritating habit of doing, but I have no idea what.


From the issue that rwacarter linked to, apparently they did something funky with their cascade resolution code in order to accommodate certain changes to the Flexbox spec, which seems to be the cause for this. Again, I don't claim to understand their reasons for doing so, but they seem to have a habit of rewriting things here and there that result in regressions all over the place. Good thing Chrome is on an evergreen rapid release cycle, eh?

like image 160
BoltClock Avatar answered Oct 23 '22 09:10

BoltClock


Definitely looks to be a bug, and a very serious/annoying one at that!

I've written a hack to help us get through it. You'll only want to run this for affected chrome versions and might want to further tailor and test it for your application:

$('body *').each(function(i, el){
    var justifyContents = $(el).css('justify-content').split(' ');
    var flexFlows = $(el).css('flex-flow').split(' ');
    if (flexFlows[0] == 'row' && justifyContents.length > 1) {
        if (justifyContents[0] == 'space-between' || justifyContents[0] == 'flex-start') {
            $(el).css('justify-content', justifyContents[0]+' left');
        } else if (justifyContents[0] == 'flex-end') {
            $(el).css('justify-content', justifyContents[0]+' right');
        }
    }
});
like image 26
Mike T Avatar answered Oct 23 '22 07:10

Mike T