Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Delphi writing to a network share using TFilestream locks the file when network is lost

Im attempting to write to a network share (local) using TFilestream. It all works fine should the network connection not be interupted.

However, if I pull the network cable and then reconnect it, subsequent attempts to open the filestream fail due to access restrictions. I also cannot even delete the file in explorer! It appears TFilestream locks the file and the only way to get around this is to reboot.

In my application, I keep the file open the whole time I am writing to it (it is a log file written once every second).

My code which fails is below:

procedure TFileLogger.SetLogFilename(const Value: String);
var line : String;
Created : Boolean;
begin
  if not DirectoryExists(ExtractFilePath(Value)) then //create the dir if it doesnt exist
  begin
       try
         ForceDirectories(ExtractFilePath(Value));
       except
         ErrorMessage(Value); //dont have access to the dir so flag an error
         Exit;
       end;
  end;
  if Value <> FLogFilename then //Either create or open existing
  begin
      Created := False;          
      if Assigned(FStream) then
         FreeandNil(FStream);
      if not FileExists(Value) then   //create the file and write header
      begin
           //now create a new file
           try
              FStream := TFileStream.Create(Value,fmCreate);
              Created := True;
           finally
             FreeAndNil(FStream);
           end;
           if not Created then //an issue with creating the file
           begin
                ErrorMessage(Value);
                Exit;
           end;
           FLogFilename := Value;
           //now open file for writing
           FStream := TFileStream.Create(FLogFilename,fmOpenWrite or fmShareDenyWrite);
           try
              line := FHeader + #13#10;
              FStream.Seek(0,soFromEnd);
              FStream.Write(Line[1], length(Line));
              FSuppress := False;
           except
              ErrorMessage(Value);  
           end;
      end else begin //just open it
           FLogFilename := Value;
           //now open file for writing
           FStream := TFileStream.Create(FLogFilename,fmOpenWrite or fmShareDenyWrite); //This line fails if the network is lost and then reconnected
      end;
  end;
end;

If anyone has any advice it would be appreciated.

like image 372
Simon Avatar asked Aug 23 '12 03:08

Simon


1 Answers

Try to close your file using Network Share API, namely NetFileEnum and NetFileClose functions. See also a related question

like image 65
kludg Avatar answered Sep 25 '22 10:09

kludg