I'm trying to create a vector of dates (formatted as character strings not as dates) using a for
loop. I've reviewed a few other SO questions such as (How to create a vector of character strings using a loop?), but they weren't helpful. I've created the following for
loop:
start_dates <- c("1993-12-01")
j <- 1
start_dates <- for(i in 1994:as.numeric(format(Sys.Date(), "%Y"))){
date <- sprintf("%s-01-01", i)
j <- j + 1
start_dates[j] <- date
}
However, it returns a NULL (empty)
vector start_dates
. When I increment the i
index manually it works. For example:
> years <- 1994:as.numeric(format(Sys.Date(), "%Y"))
> start_dates <- c("1993-12-01")
> j <- 1
> i <- years[1]
> date <- sprintf("%s-01-01", i)
> j <- j + 1
> start_dates[j] <- date
> start_dates
[1] "1993-12-01" "1994-01-01"
> i <- years[2]
> date <- sprintf("%s-01-01", i)
> j <- j + 1
> start_dates[j] <- date
> start_dates
[1] "1993-12-01" "1994-01-01" "1995-01-01"
It must have something to do with the construction of my for()
statement, but I can't figure it out. I'm sure it's super simple. Thanks in advance.
What is wrong with:
sprintf("%s-01-01", 1994:2015)
> sprintf("%s-01-01", 1994:2015)
[1] "1994-01-01" "1995-01-01" "1996-01-01" "1997-01-01" "1998-01-01"
[6] "1999-01-01" "2000-01-01" "2001-01-01" "2002-01-01" "2003-01-01"
[11] "2004-01-01" "2005-01-01" "2006-01-01" "2007-01-01" "2008-01-01"
[16] "2009-01-01" "2010-01-01" "2011-01-01" "2012-01-01" "2013-01-01"
[21] "2014-01-01" "2015-01-01"
sprintf()
is fully vectorised, take advantage of this.
The main problem is that you are assigning the value of the for()
function to start_dates
when the for()
finished, hence overwriting all the hard work your loop did. This is effectively what is happening:
j <- 1
foo <- for (i in 1:10) {
j <- j + 1
}
foo
> foo
NULL
And reading ?'for'
we see that this behaviour is by design:
Value:
....
‘for’, ‘while’ and ‘repeat’ return ‘NULL’ invisibly.
Solution: Don't assign the returned value of for()
. Hence the template might be:
for(i in foo) {
# ... do stuff
start_dates[j] <- bar
}
Fix that and you still have a problem; j
will be 2
by the time you assign the first date to the output as you start with j <- 1
and increment it before assigning in the loop.
This would be easier if you made i
take values from a sequence 1, 2, ..., n rather than the actual years you want. You can use i
to index the years vector and as an index for the elements of start_dates
too.
Not that you should do the loop this way, but, if you wanted too...
years <- seq.int(1994, 2015)
start_dates <- numeric(length = length(years))
for (i in seq_along(years)) {
start_dates[i] <- sprintf("%s-01-01", years[i])
}
which would give:
> start_dates
[1] "1994-01-01" "1995-01-01" "1996-01-01" "1997-01-01" "1998-01-01"
[6] "1999-01-01" "2000-01-01" "2001-01-01" "2002-01-01" "2003-01-01"
[11] "2004-01-01" "2005-01-01" "2006-01-01" "2007-01-01" "2008-01-01"
[16] "2009-01-01" "2010-01-01" "2011-01-01" "2012-01-01" "2013-01-01"
[21] "2014-01-01" "2015-01-01"
Sometimes it is helpful to loop over the actual values in a vector (as you did) rather than it's indices (as I just did), but only in specific cases. For general operations like you have here, it is just an additional complication you need to work around. That said, think about doing vectorised operations in R before resorting to a loop.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With