Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Conditional validation on model in MVC

Tags:

asp.net-mvc

I have a view & model that I use for both the edit and the insert page for a record. One of the business requirements is that a certain field is required on edit but not on new. Originally before this particular feature was added to the docket, i had the model like so:

[Required(ErrorMessage = "*")]
[Range(0.0, (double)decimal.MaxValue)]
[DisplayName("Cost")]
[DisplayFormat(DataFormatString = "{0:d}", ApplyFormatInEditMode = true)]
public decimal ProposedCost { get; set; }

I would like to either remove the required property if it is an insert form, or add it if an edit form. What is the better approach? All my other validation is done like above. Or can I alter the model state? Thoughts?

EDIT

Something I should clarify is that they are still permitted to insert a cost on new, just not required.

like image 243
Seth Avatar asked Jul 31 '13 12:07

Seth


3 Answers

If you're on MVC3/.NET4, you can use IValidatableObject which exists specifically for such purposes.

Quoting ScottGu,

...The IValidatableObject interface enables you to perform model-level validation, and enables you to provide validation error messages specific to the state of the overall model....

You model would look like

public class MyViewModel : IValidatableObject
{
    public long? Id { get; set; }
    public decimal? ProposedCost { get; set; }

    public IEnumerable<ValidationResult> Validate(ValidationContext validationContext) 
    { 
        if (Id != null && ProposedCost == 0) {
            yield return new ValidationResult("ProposedCost must be provided.");
        }
    }
}

and then in the controller,

[HttpPost]
public ActionResult Submit(MyViewModel model)
{
    if (!ModelState.IsValid) {
        //failed - report an error, redirect to action etc
    }
    //succeeded - save to database etc
}

Otherwise, the most clean solution would be to use view models - UpdateViewModel where the property is required, and CreateViewModel where it's not required.

like image 108
andreister Avatar answered Oct 17 '22 05:10

andreister


There is the MVC Foolproof library: http://foolproof.codeplex.com/

For example you would need to have something like this in your model:

[RequiredIfTrue("Required", ErrorMessage = "*")]
[Range(0.0, (double)decimal.MaxValue)]
[DisplayName("Cost")]
[DisplayFormat(DataFormatString = "{0:d}", ApplyFormatInEditMode = true)]
public decimal ProposedCost { get; set; }

public bool Required { get; set; }

You would then need to set the Required property based on which form the model is going to.

You will also need a hidden input field on the form to represent the Required property if you wish to perform client side validation.

Hope that helps...

like image 31
pkunal7 Avatar answered Oct 17 '22 04:10

pkunal7


You could use the RequiredIf validation attribute from the MVC Foolproof Validation project. I've used it on projects to enable just the functionality you require.

An alternative would be to use the RemoteAttribute and implement the logic yourself in a method.

like image 22
christophano Avatar answered Oct 17 '22 04:10

christophano