Change button text after click, then change it back after clicking again

Question

I am trying to change the text of a Button every time its clicked.

Button Starts as "ON". When I click it the first time it should change to "OFF", and when I click it again, it should change back to On.

I understand how to change it to "OFF" when clicked, but I am unsure as to how to check for a secondary click so I can change the text back to "ON".

Here is my code so far:

private void OrdersButton_Click(object sender, EventArgs e)
{
       OrdersButton.Text = " Turn Orders Off";
}

Answer 1

Try

    private void OrdersButton_Click(object sender, EventArgs e)
    {
        if (OrdersButton.Text == "Turn Orders On")
        {
            OrdersButton.Text = "Turn Orders Off";
        }
        else if (OrdersButton.Text == "Turn Orders Off")
        {
            OrdersButton.Text = "Turn Orders On";
        }
    }

Hope this helps.

Answer 2

I can see several possible problems with that and can offer a more object oriented solution: Adding a property that keeps track of the current "state":

    private bool _IsOn;

    public bool IsOn
    {
        get
        {
            return _IsOn;
        }
        set
        {
            _IsOn = value;
            OrdersButton.Text = _IsOn ? "On" : "Off";
        }
    }

and using the event handler to simply toggle the property:

private void OrdersButton_Click(object sender, EventArgs e)
{
     IsOn = !IsOn;
}

That way it's easier to access the information later on and you can easily replace on/off with whatever you like - even globalize/localize it if required. I think it's a very bad programming practice to have code depend on the text that is on the display...

EDIT: Also, wouldn't using a checkbox or a togglebutton make more sense? Other than the visual representation being different, it does what you want out of the box...