Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Can std::make_unique be used with abstract interface?

Consider the following line of code:

auto source1 = std::unique_ptr<IGpsSource>(new GpsDevice(comPort, baudrate));
auto source2 = std::unique_ptr<IGpsSource>(new GpsLog(filename));

How can that be written using the new std::make_unique function, supported by VS 2013? Is it even possible?*

*My problem is that I don't know how to tell std::make_unique what kind of object to instantiate. Because only the constructor's parameters are passed in there seems to be no control over that.

like image 680
Boris Avatar asked Oct 14 '14 07:10

Boris


2 Answers

Yes, you can of course use make_unique for that, but it's not as useful as you might want. You have these options:

std::unique_ptr<IGpsSource> source1 = std::make_unique<GpsDevice>(comPort, baudrate);
auto source2 = std::unique_ptr<IGpsSource>{ std::make_unique<GpsLog>(filename) };

I would say the real question is "why do you want that?"

  1. Unlike make_shared, make_unique has no allocation benefits over new. So if you need control of the pointer's type, what you're doing is just fine.

  2. Why do you need the pointer to be typed to IGpsSource in the first place? An implicit conversion from std::unique_ptr<Derived> rvalues to std::unique_ptr<Base> rvalues exists. So if you're actually calling make_unique to initialise an IGpsSource pointer, it will work just fine. And if you want to transfer the pointer somewhere, you'll have to std::move it anyway, at which point the conversion can happen again.

like image 69
Angew is no longer proud of SO Avatar answered Oct 10 '22 10:10

Angew is no longer proud of SO


std::unique_ptr<Base> base_ptr = std::make_unique<Derived>();

As Angew said, the above should work fine. Provided Derived uses public inheritance. Just wanted to add that for completeness.

like image 20
Ajmal Kunnummal Avatar answered Oct 10 '22 08:10

Ajmal Kunnummal