Caching Data Objects when using Repository/Service Pattern and MVC

Question

I have an MVC-based site, which is using a Repository/Service pattern for data access. The Services are written to be using in a majority of applications (console, winform, and web). Currently, the controllers communicate directly to the services. This has limited the ability to apply proper caching.

I see my options as the following:

• Write a wrapper for the web app, which implements the IWhatEverService which does caching.
• Apply caching in each controller by cache the ViewData for each Action.
• Don't worry about data caching and just implement OutputCaching for each Action.

I can see the pros and cons of each. What is/should the best practice be for caching with Repository/Service

Answer 1

Steve Smith did two great blog posts which demonstrate how to use his CachedRepository pattern to achieve the result you're looking for.

Introducing the CachedRepository Pattern

Building a CachedRepository via Strategy Pattern

In these two posts he shows you how to set up this pattern and also explains why it is useful. By using this pattern you get caching without your existing code seeing any of the caching logic. Essentially you use the cached repository as if it were any other repository.

public class CachedAlbumRepository : IAlbumRepository {     private readonly IAlbumRepository _albumRepository;      public CachedAlbumRepository(IAlbumRepository albumRepository)     {         _albumRepository = albumRepository;     }      private static readonly object CacheLockObject = new object();      public IEnumerable<Album> GetTopSellingAlbums(int count)     {         Debug.Print("CachedAlbumRepository:GetTopSellingAlbums");         string cacheKey = "TopSellingAlbums-" + count;         var result = HttpRuntime.Cache[cacheKey] as List<Album>;         if (result == null)         {             lock (CacheLockObject)             {                 result = HttpRuntime.Cache[cacheKey] as List<Album>;                 if (result == null)                 {                     result = _albumRepository.GetTopSellingAlbums(count).ToList();                     HttpRuntime.Cache.Insert(cacheKey, result, null,                          DateTime.Now.AddSeconds(60), TimeSpan.Zero);                 }             }         }         return result;     } }