Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

c++ visitor pattern: Why should every derived visited implement Accept()?

I've seen a couple of examples that demonstrate the visitor pattern. In all of them, each derived visited element implements what's usually called the Accept() method.

In a hierarchy of colors, this method might look like:

void Red::accept(Visitor *v)
{
    v->visit(*this);
}

void Blue::accept(Visitor *v)
{
    v->visit(*this);
}

When Visitor, as well as its inheritors, have the methods:

visit(Red red);
visit(Blue blue)

My question is why not implement this in the same way only in the base class (in this example: Color) and polymorphism will do the job, namely, the correct visit will be called since when the object is a Red the this's dynamic type is a Red so dereferencing it will yield a Red which in turn will cause the visit(red) to be called?

What am I missing?

like image 273
Subway Avatar asked Jun 19 '13 12:06

Subway


2 Answers

Inheritance polymorphism (dynamic dispatch) does not apply to function arguments. In other words, overloaded function are selected on the static type of the arguments being passed. If implemented in the base class Color, the v->visit(*this) would always call visit(Color c).

like image 60
rectummelancolique Avatar answered Sep 21 '22 07:09

rectummelancolique


If the only accept you had was...

void Color::accept(Visitor* v)
{
    v->visit(*this);
}

visit would just get called with a base class. In order to call visit with the correct derived class you need each Color to implement it so they can pass a correctly typed this, so the correct visit overload is called.

like image 28
David Avatar answered Sep 24 '22 07:09

David