Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

C : Value escapes local scope?

Tags:

c

clion

So I have the following toString function:

/*
 * Function: toString
 * Description: traduces transaction to a readable format
 * Returns: string representing transaction
 */

 char* toString(Transaction* transaction){
    char transactStr[70];

    char id[10];
    itoa(transaction -> idTransaction,id, 10);
    strcat(transactStr, id);

    strcat(transactStr, "\t");

    char date[15];
    strftime(date,14,"%d/%m/%Y %H:%M:%S",transaction -> date);
    strcat(transactStr, date);

    strcat(transactStr, "\t");

    char amount[10];
    sprintf(amount,"%g",transaction -> amount);
    strcat(transactStr,"$ ");
    strcat(transactStr, amount);

    return transactStr;
}

CLion highlights the return line with a warning: Value escapes local scope (referring to transactStr)

I need to know why this is happening (I'm new to C, btw)

like image 923
Lautaro Paskevicius Avatar asked May 27 '17 22:05

Lautaro Paskevicius


1 Answers

You've defined a local variable pointer (edit thanks) inside that function and are trying to return it.

That's a no-no, as the variable's lifetime is only that of it's enclosing scope, here, the function call. Anyone trying to reference the return value will trigger undefined behavior, usually a crash, if you're lucky.

If you want to return the array, you need to pass it in as an argument.

like image 86
Ron Thompson Avatar answered Oct 15 '22 06:10

Ron Thompson