Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

C# encoding in DES encryption/decryption

My main method runs without errors, but the decrypted message is not correct. I'm almost certain I'm not properly encoding, but I can't nail down the problem. Any help would be greatly appreciated.

This is my first post, so if I've inadvertently broken a rule or not adhered to a guideline, please let me know.

static void Main(string[] args)
{
    string unencryptedString = "cat";
    string encryptedString;
    string decryptedString;

    string password = "password";

    System.Console.WriteLine("Unencrypted String: " + unencryptedString);
    System.Console.WriteLine("Password: " + password);

    encryptedString = StandardEncryptor.Encrypt(unencryptedString, password);
    System.Console.WriteLine("Encrypted String: " + encryptedString);

    decryptedString = StandardEncryptor.Decrypt(encryptedString, password);
    System.Console.WriteLine("Decrypted String: " + decryptedString);

    System.Console.ReadLine();
}

public static string Encrypt(string message, string password)
{
    // Encode message and password
    byte[] messageBytes = ASCIIEncoding.ASCII.GetBytes(message);
    byte[] passwordBytes = ASCIIEncoding.ASCII.GetBytes(password);

    // Set encryption settings -- Use password for both key and init. vector
    DESCryptoServiceProvider provider = new DESCryptoServiceProvider();
    ICryptoTransform transform = provider.CreateEncryptor(passwordBytes, passwordBytes);
    CryptoStreamMode mode = CryptoStreamMode.Write;

    // Set up streams and encrypt
    MemoryStream memStream = new MemoryStream();
    CryptoStream cryptoStream = new CryptoStream(memStream, transform, mode);
    cryptoStream.Write(messageBytes, 0, messageBytes.Length);
    cryptoStream.FlushFinalBlock();

    // Read the encrypted message from the memory stream
    byte[] encryptedMessageBytes = new byte[memStream.Length];
    memStream.Position = 0;
    memStream.Read(encryptedMessageBytes, 0, encryptedMessageBytes.Length);

    // Encode the encrypted message as base64 string
    string encryptedMessage = Convert.ToBase64String(encryptedMessageBytes);

    return encryptedMessage; 
}

public static string Decrypt(string encryptedMessage, string password)
{
    // Convert encrypted message and password to bytes
    byte[] encryptedMessageBytes = Convert.FromBase64String(encryptedMessage);
    byte[] passwordBytes = ASCIIEncoding.ASCII.GetBytes(password);

    // Set encryption settings -- Use password for both key and init. vector
    DESCryptoServiceProvider provider = new DESCryptoServiceProvider();
    ICryptoTransform transform = provider.CreateDecryptor(passwordBytes, passwordBytes);
    CryptoStreamMode mode = CryptoStreamMode.Write;

    // Set up streams and decrypt
    MemoryStream memStream = new MemoryStream();
    CryptoStream cryptoStream = new CryptoStream(memStream, transform, mode);
    cryptoStream.Write(encryptedMessageBytes, 0, encryptedMessageBytes.Length);
    cryptoStream.FlushFinalBlock();

    // Read decrypted message from memory stream
    byte[] decryptedMessageBytes = new byte[memStream.Length];
    memStream.Position = 0;
    memStream.Read(decryptedMessageBytes, 0, decryptedMessageBytes.Length);

    // Encode deencrypted binary data to base64 string
    string message = Convert.ToBase64String(decryptedMessageBytes);

    return message;
}
like image 507
Dave Avatar asked Nov 04 '10 20:11

Dave


People also ask

What C is used for?

C programming language is a machine-independent programming language that is mainly used to create many types of applications and operating systems such as Windows, and other complicated programs such as the Oracle database, Git, Python interpreter, and games and is considered a programming foundation in the process of ...

What is the full name of C?

In the real sense it has no meaning or full form. It was developed by Dennis Ritchie and Ken Thompson at AT&T bell Lab. First, they used to call it as B language then later they made some improvement into it and renamed it as C and its superscript as C++ which was invented by Dr.

What is C in C language?

What is C? C is a general-purpose programming language created by Dennis Ritchie at the Bell Laboratories in 1972. It is a very popular language, despite being old. C is strongly associated with UNIX, as it was developed to write the UNIX operating system.

Is C language easy?

C is a general-purpose language that most programmers learn before moving on to more complex languages. From Unix and Windows to Tic Tac Toe and Photoshop, several of the most commonly used applications today have been built on C. It is easy to learn because: A simple syntax with only 32 keywords.


1 Answers

Is the problem on the second to last line?

string message = Convert.ToBase64String(decryptedMessageBytes);

I may be off track here but I don't think you intended to convert the string bytes back to base64. Do you just need to convert the bytes back to a string?

string message = ASCIIEncoding.ASCII.FromBytes(decryptedMessageBytes);
like image 96
Steve Avatar answered Nov 14 '22 19:11

Steve