Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

C#: best practice to overload == operator when it comes to null references

Tags:

c#

.net

what is the best practice to overload == operator that compares two instances of the same class when it comes to null reference comparison?

MyObject o1 = null;
MyObject o2 = null;
if (o1 == o2) ... 


static bool operator == (MyClass o1, MyClass o2)
{
  // ooops! this way leads toward recursion with stackoverflow as the result
  if (o1 == null && o2 == null) 
    return true;   

  // it works!
  if (Equals(o1, null) && Equals(o2, null))
    return true;

  ... 
}

What is the best approach to handle null references in comparison ?

like image 975
Andrew Florko Avatar asked Nov 02 '10 07:11

Andrew Florko


People also ask

What C is used for?

C programming language is a machine-independent programming language that is mainly used to create many types of applications and operating systems such as Windows, and other complicated programs such as the Oracle database, Git, Python interpreter, and games and is considered a programming foundation in the process of ...

What is C in C language?

What is C? C is a general-purpose programming language created by Dennis Ritchie at the Bell Laboratories in 1972. It is a very popular language, despite being old. C is strongly associated with UNIX, as it was developed to write the UNIX operating system.

Is C language easy?

Compared to other languages—like Java, PHP, or C#—C is a relatively simple language to learn for anyone just starting to learn computer programming because of its limited number of keywords.

What is the full name of C?

In the real sense it has no meaning or full form. It was developed by Dennis Ritchie and Ken Thompson at AT&T bell Lab. First, they used to call it as B language then later they made some improvement into it and renamed it as C and its superscript as C++ which was invented by Dr.


3 Answers

I've wondered if there is a "best approach". Here's how I do it:

static bool operator == (MyClass o1, MyClass o2)
{
  if(object.ReferenceEquals(o1, o2)) // This handles if they're both null
      return true;                   // or if it's the same object

  if(object.ReferenceEquals(o1, null))
      return false;

  if(object.ReferenceEquals(o2, null)) // Is this necessary? See Gabe's comment
       return false;

  return o1.Equals(o2);

}
like image 92
Andrew Shepherd Avatar answered Nov 07 '22 11:11

Andrew Shepherd


This is approach I follow:

http://msdn.microsoft.com/en-us/library/336aedhh.aspx

like image 38
klm_ Avatar answered Nov 07 '22 09:11

klm_


if (ReferenceEquals(o1, null) && ReferenceEquals(o2, null))
    return true;

etc

like image 1
Itay Karo Avatar answered Nov 07 '22 11:11

Itay Karo