Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

button onclick function firing twice

I have a button that calls a javascript function using an event handler. For some reason, the event handler is being called twice.

Here is my button (I am using a php object to generate the code, that's why there are a lot of empty tags):

<button name="addToCart" value="" size="" onclick="" src="" class="addToCartButton" id="0011110421111" type="button" formtarget="_self" formmethod="post" formaction="" data-mini="true" width="" height="" placeholder="" data-mini="1" onkeypress="" >Add To Cart</button> 

Here is my event handler:

$('.addToCartButton').click(function() {     alert("bob");     //addToCart($(this).attr("id")); }); 

Here, I am getting the alert twice.

I have tried calling the function addToCart in the button's onclick property, but if I try it that way, I get this error:

TypeError: '[object HTMLButtonElement]' is not a function (evaluating 'addToCart(0011110421111)') 

I have also tried event.preventDefault() and event.stopPropagation(), and neither worked.

Any ideas why this is happening, or what I can do to stop it from executing twice, or maybe why I am getting an error if I call the javascript function from onclick=""?

like image 676
Jason247 Avatar asked Nov 18 '13 18:11

Jason247


2 Answers

Maybe you are attaching the event twice on the same button. What you could do is unbind any previously set click events like this:

$('.addToCartButton').unbind('click').click(function() {     alert("bob");     //addToCart($(this).attr("id")); }); 

This works for all attached events (mouseover, mouseout, click, ...)

like image 200
Mike Vranckx Avatar answered Sep 24 '22 14:09

Mike Vranckx


My event was firing twice because I accidentally included both my_scripts.js AND my_scripts.min.js. Ensure you only include one.

like image 25
user1491819 Avatar answered Sep 22 '22 14:09

user1491819