Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Backbone does POST instead of PUT on updates when composite key is used

I'm using a composite key in my model and generate the ID based on my composite key:

app.Assignment = Backbone.Model.extend({
    idAttribute : [ 'personId', 'jobId' ],
    parse : function(resp) {
        resp.id = resp.personId + "_" + resp.jobId;
        return resp;
    }
});

but Backbone still thinks that all instances of Assignment are new, allthough I'm setting the id in the parse method when fetching them from the API. As a result Backbone does no DELETEs and does a POST instead of PUT on updates. How can I work around this or what is the "right way" to do it?

Update:

Looks like replacing resp.id with this.id solves the issue.

like image 649
i-- Avatar asked Mar 04 '13 10:03

i--


2 Answers

The results of the parse method of a Backbone.Model are passed to the set method, which sets the attributes of the model. The point of confusion for you I think is that the model's ID isn't one of it's attributes; it's one of its properties.

So, what happens is this:

  1. Your raw data comes back from the server and is passed to parse
  2. That same raw data, now augmented with a id attribute, is passed to set
  3. set looks and your idAttribute ([ 'personId', 'jobId' ]) and all of the keys in the raw data
  4. Since none of those keys match the idAttribute, none of them are used as the model's ID, and thus you get your problem.

Your solution of setting this.id inside parse works, but it might cause problems down the road because parse is generally designed to operate on it's input (the raw data), not to modify the model itself; that part is supposed to happen next when set is called. A cleaner solution would instead be to do something like the following:

app.Assignment = Backbone.Model.extend({
    // note that no idAttribute is specified, leaving it as the default "id"
    parse : function(resp) {
        resp.id = resp.personId + "_" + resp.jobId;
        return resp;
    }
}

Or, if you want a different ID attribute ...

app.Assignment = Backbone.Model.extend({
    idAttribute: 'personAndJobId',
    parse : function(resp) {
        resp.personAndJobId = resp.personId + "_" + resp.jobId;
        return resp;
    }
}
like image 66
machineghost Avatar answered Oct 29 '22 23:10

machineghost


Aside from the idAttribute issues here, you can always force Backbone to use a certain HTTP method via the type options passed to save().

model.save(null, { type: 'put' })

like image 35
Lincoln B Avatar answered Oct 29 '22 23:10

Lincoln B