Menu
I have created a pull request in GitHub that has been reviewed and the reviewer has requested changes. I have done the changes and added a comment in the pull request conversation with a reference to the reviewer so I expect a notification has been sent to him.
Is there any other thing I must do in GitHub to reflect that I have pushed corrections to the requested changes?
881
On the pull request, click Files changed. Above the changed code, click Review changes. Type a comment summarizing your feedback on the proposed changes. Select Comment to leave general feedback without explicitly approving the changes or requesting additional changes.
After receiving the pull request, the project maintainer has to decide what to do. If the feature is ready to go, they can simply merge it into main and close the pull request. But, if there are problems with the proposed changes, they can post feedback in the pull request.
What you did is standard operating procedure when replying to a change request in a pull request. Since you pushed your changes, the branch in question has been updated. If your reviewer's GitHub is configured to not receive notifications he may not have received one, but from your point of view you have met your expectations. The other Git repositories (e.g. Bitbucket) also behave similarly to this.
149
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
