ActionController::UrlGenerationError, No route matches

Question

I've read through every similar question I could find and still can't figure out my problem.

# routes.rb
Rails.application.routes.draw do
  resources :lists, only: [:index, :show, :create, :update, :destroy] do
    resources :items, except: [:new]
  end
end

---

# items_controller.rb (excerpt)
class ItemsController < ApplicationController
  ...

  def create
    @list = List.find(params[:list_id])
    ...
  end
  ...
end

---

# items_controller_spec.rb (excerpt)
RSpec.describe ItemsController, type: :controller do
   ...

  let!(:list) { List.create(title: "New List title") }

  let(:valid_item_attributes) {
    { title: "Some Item Title", complete: false, list_id: list.id }
  }

  let!(:item) { list.items.create(valid_item_attributes) }
  describe "POST #create" do
    context "with valid params" do
      it "creates a new item" do
        expect {
          post :create, { item: valid_item_attributes, format: :json  }
        }.to change(Item, :count).by(1)
      end
    end
  end
  ...
end

And the RSpec error:

1) ItemsController POST #create with valid params creates a new item
     Failure/Error: post :create, { item: valid_item_attributes, format: :json  }
     ActionController::UrlGenerationError:
       No route matches {:action=>"create", :controller=>"items", :format=>:json, :item=>{:title=>"Some Item Title", :complete=>false, :list_id=>1}}

The output from rake routes:

list_items     GET    /lists/:list_id/items(.:format)          items#index
               POST   /lists/:list_id/items(.:format)          items#create
edit_list_item GET    /lists/:list_id/items/:id/edit(.:format) items#edit
     list_item GET    /lists/:list_id/items/:id(.:format)      items#show
               PATCH  /lists/:list_id/items/:id(.:format)      items#update
               PUT    /lists/:list_id/items/:id(.:format)      items#update
               DELETE /lists/:list_id/items/:id(.:format)      items#destroy

I can successfully create a new item in an existing list via curl which tells me that the route is ok, I must be doing something wrong in my test.

curl -i -X POST -H "Content-Type:application/json" -H "X-User-Email:[email protected]" -H "X-Auth-xxx" -d '{ "item": { "title": "new item", "complete": "false"} }' http://localhost:3000/lists/5/items

I am really confused. My routes are setup correctly. A ItemsController#create method definitely exists. The rest of the tests in items_controller_spec.rb pass without issue.

Am I missing something obvious?

Answer 1

Here are the fixes I had to make to my tests (items_controller_spec.rb). I was not passing the correct hash to post create:.

  describe "POST #create" do
    context "with valid params" do
      it "creates a new item" do
        expect {
          post :create, { list_id: list.id, item: valid_item_attributes, format: :json  }
        }.to change(Item, :count).by(1)
      end

      it "assigns a newly created item as @item" do
        post :create, { list_id: list.id, item: valid_item_attributes, format: :json  }

        expect(assigns(:item)).to be_a(Item)
        expect(assigns(:item)).to be_persisted
      end
    end # "with valid params"

    context "with invalid params" do
      it "assigns a newly created but unsaved item as @item" do
        post :create, { list_id: list.id, item: invalid_item_attributes, format: :json  }

        expect(assigns(:item)).to be_a_new(Item)
      end

      it "returns unprocessable_entity status" do
        put :create, { list_id: list.id, item: invalid_item_attributes, format: :json }

        expect(response.status).to eq(422)
      end
    end # "with invalid params"
  end # "POST #create"

Answer 2

I've received the same error and fixed it in a different way. I'm using Rails ~> 5.0.7.

ROUTES

This is the output from running rake routes CONTROLLER=bills:

 Prefix            Verb   URI Pattern                                  Controller#Action
download_site_bill GET    /sites/:site_id/bills/:id/download(.:format) bills#download
        site_bills GET    /sites/:site_id/bills(.:format)              bills#index
                   POST   /sites/:site_id/bills(.:format)              bills#create
     new_site_bill GET    /sites/:site_id/bills/new(.:format)          bills#new
    edit_site_bill GET    /sites/:site_id/bills/:id/edit(.:format)     bills#edit
         site_bill GET    /sites/:site_id/bills/:id(.:format)          bills#show
                   PATCH  /sites/:site_id/bills/:id(.:format)          bills#update
                   PUT    /sites/:site_id/bills/:id(.:format)          bills#update
                   DELETE /sites/:site_id/bills/:id(.:format)          bills#destroy
             bills GET    /bills(/page/:page)(.:format)                bills#index
     download_bill GET    /bills/:id/download(.:format)                bills#download
                   GET    /bills(.:format)                             bills#index
                   POST   /bills(.:format)                             bills#create
          new_bill GET    /bills/new(.:format)                         bills#new
         edit_bill GET    /bills/:id/edit(.:format)                    bills#edit
              bill GET    /bills/:id(.:format)                         bills#show
                   PATCH  /bills/:id(.:format)                         bills#update
                   PUT    /bills/:id(.:format)                         bills#update
                   DELETE /bills/:id(.:format)                         bills#destroy

---

REFERENCE CODE

# controllers/admin/bills_controller.rb (excerpt)

module Admin
 class BillsController < ApplicationController

    ...

    def edit
      authorize(@bill)
    end
  end
end

---

# spec/controllers/admin/bills_controller_spec.rb (excerpt)

require 'rails_helper'

RSpec.describe Admin::BillsController, type: :controller do
 ...

    context 'as an AdminUser' do
      login_admin_user

      it 'loads the bill edit page' do
        request.host = 'admin.example.com'
        get :edit, { id: bill }
        expect(response.status).to eq(200)
      end
    end
  end
end

---

# Error message

2) Admin::BillsController GET bills/:id/edit as a User redirects to the home page
     Failure/Error: get :edit

     ActionController::UrlGenerationError:
       No route matches {:action=>"edit", :controller=>"admin/bills"}

---

POTENTIAL SOLUTION

I tried variations of this solution. It may work for others, but I got this error:

Failure/Error: require 'admin/bills_controller'

LoadError:
  cannot load such file -- admin/bills_controller

SOLUTION

I tried Case 2 in this github issues and it worked. The changes I made to my code were to add this params: { use_route: 'admins/bills/', id: bill.id }. Below is the context of this addition:

context 'as an AdminUser' do
   login_admin_user

   it 'loads the bill edit page' do
     request.host = 'admin.example.com'
     get :edit, params: { use_route: 'admins/bills/', id: bill.id }
     expect(response.status).to eq(200)
   end
 end