Access to Modified Closure

Question

string [] files = new string[2]; files[0] = "ThinkFarAhead.Example.Settings.Configuration_Local.xml"; files[1] = "ThinkFarAhead.Example.Settings.Configuration_Global.xml";  //Resharper complains this is an "access to modified closure" for (int i = 0; i < files.Length; i++ ) {     // Resharper disable AccessToModifiedClosure     if(Array.Exists(Assembly.GetExecutingAssembly().GetManifestResourceNames(),     delegate(string name) { return name.Equals(files[i]); }))          return Assembly.GetExecutingAssembly().GetManifestResourceStream(files[i]);     // ReSharper restore AccessToModifiedClosure } 

The above seems to work fine though ReSharper complains that this is "access to modified closure". Can any one shed light on this?

(this topic continued here)

Answer 1

In this case, it's okay, since you are actually executing the delegate within the loop.

If you were saving the delegate and using it later, however, you'd find that all of the delegates would throw exceptions when trying to access files[i] - they're capturing the variable i rather than its value at the time of the delegates creation.

In short, it's something to be aware of as a potential trap, but in this case it doesn't hurt you.

See the bottom of this page for a more complex example where the results are counterintuitive.