Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Yarn Build - Babel-loader issues with Storybook

I have a new create react app project, using the typescript template:

yarn create react-app my-app --template typescript

To this, I have added Storybook with:

npx sb init

This has given me a working storybook instance, however, yarn build now errors.

$ react-scripts build

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "babel-loader": "8.1.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-loader was detected higher up in the tree:

  /home/michael/pgit/my-app/node_modules/babel-loader (version: 8.2.2)

Manually installing incompatible versions is known to cause hard-to-debug issues.

If you would prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.

To fix the dependency tree, try following the steps below in the exact order:

  1. Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
  2. Delete node_modules in your project folder.
  3. Remove "babel-loader" from dependencies and/or devDependencies in the package.json file in your project folder.
  4. Run npm install or yarn, depending on the package manager you use.

In most cases, this should be enough to fix the problem.
If this has not helped, there are a few other things you can try:

  5. If you used npm, install yarn (http://yarnpkg.com/) and repeat the above steps with it instead.
     This may help because npm has known issues with package hoisting which may get resolved in future versions.

  6. Check if /home/michael/pgit/my-app/node_modules/babel-loader is outside your project directory.
     For example, you might have accidentally installed something in your home folder.

  7. Try running npm ls babel-loader in your project folder.
     This will tell you which other package (apart from the expected react-scripts) installed babel-loader.

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.

P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!

So babel-loader is not in any of my package.json files, and babel is all supposed to be handled by CRA (hence the warning not to add it yourself.)

I can use the SKIP_PREFLIGHT_CHECK - but that's masking the potential conflict, what is the correct way to get the two libraries pre-requisites to play together?

like image 744
THEMike Avatar asked Dec 13 '20 21:12

THEMike


Video Answer


3 Answers

It is a known issue.

If you are using yarn, you can easily get around it using resolutions. Add the following to your package.json to allow yarn to resolve babel-loader version 8.1.0 (the version required by CRA, not Storybook):

"resolutions": {
  "babel-loader": "8.1.0"
},

After that, make sure to run yarn install to refresh your dependencies and update yarn.lock file

like image 154
noor Avatar answered Oct 18 '22 00:10

noor


For anyone facing the same issue with npm. I fixed it by deleting package-lock.json, node_modules.

EDIT: Leaving babel-loader implicit version in package.json is possible by using --legacy-peer-deps param for both npm i and npm dedupe:

npm i --leagcy-peer-deps

To make sure the problem lies in corrupted dependency tree I ran:

npm ls babel-loader

Finally

npm dedupe --legacy-peer-deps

fixed the issue with wrong dependency tree. It is also applicable to webpack version mismatch issue.

like image 2
jckmlczk Avatar answered Oct 17 '22 22:10

jckmlczk


Adding "babel-loader": "8.1.0" to both "devDependencies" and "dependencies" in package.json file and then doing yarn to build ,seems to work as of now.Its a known issue and has been open for nearly 2 years now https://github.com/storybookjs/storybook/issues/5183

like image 1
Ritwik Avatar answered Oct 18 '22 00:10

Ritwik