Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

XML to LINQ with Checking Null Elements

The situation I am faced with is parsing an XML document into an object using Linq. During the parse I am checking to make sure Elements are not null before proceeding to parse out their values. Is there anyway to simplify this statement?

  var variable = (from x in xdoc.Descendants("Root")
                 select new AccountingResponse
                 {      
                 NetCharge = x.Element("Charges") != null && x.Element("Charges").Element("NetCharge") != null ? x.Element("Charges").Element("NetCharge").Value : "0",
                 TotalCharge = x.Element("Charges") != null && x.Element("Charges").Element("TotalCharge") != null ? x.Element("Charges").Element("TotalCharge").Value : "0"
                 }).SingleOrDefault();

To summarize, I do not want to continue to check if the nodes exist on each line. I know I can test to see if the node exists prior to the parsing, but there may be other data that needs parsed to create the AccountingResponse and I want to avoid if statements that only parse a portion of the XML out at a time.

Or perhaps I'm doing this completely wrong and there's a better way!

like image 324
cgatian Avatar asked Dec 15 '22 12:12

cgatian


1 Answers

One simple option is to use Elements rather than Element - that will return a zero-length sequence if the element isn't present. So you can use:

from x in xdoc.Descendants("Root")
select new AccountingResponse
{      
    NetCharge = x.Elements("Charges")
                 .Elements("NetCharge")
                 .Select(y => (int) y)
                 .FirstOrDefault(),
    TotalCharge = x.Elements("Charges")
                   .Elements("TotalCharge")
                   .Select(y => (int) y)
                   .FirstOrDefault(),
}).SingleOrDefault();

(Note that your original code wouldn't compile, as Value is a string whereas 0 is an int...)

like image 122
Jon Skeet Avatar answered Feb 19 '23 05:02

Jon Skeet