Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Writing a test for a directive that does a full page reload in Karma

I would like to unit-test a directive that redirects a user to the social login-url at the backed.

since Karma doesn't support full page reloads, I would like to alter the behavior of the location.href JavaScript object to output the parameter that it receives to an HTML element with a certain ID, and I am having difficulties to do that.

directive:

__app.directive('socialAuth', function(utils, authService, $location){
    return{
            restrict: 'A',
            scope: false,
            link: function(scope, elem, attrs){
                elem.bind('click', function(){
                            utils.cleanSocialSearch();
                            if(attrs.checkbox == 'personal'){
                              scope.$apply(function(){
                                scope.model.personalShare[attrs.network] = true;  
                                $location.search('personalShare', '1');
                              });
                            }
                            else if(attrs.checkbox == 'group'){
                              scope.$apply(function(){
                                var __index = attrs.checkbox + '_' + attrs.network;
                                scope.model.personalShare[__index] = true;  
                                $location.search('groupShare', '1');
                              });
                            }
                              var callback = encodeURIComponent(window.location.href);
                              var loginUrl = utils.getBaseUrl() + '/social/login/' + attrs.network + '?success_url=' + callback;
                              location.href = loginUrl;  

                        });
            }
    }

});

Test with an attempt to mock the location.href object(yeah, I know it's not a function):

var location = {//an attempt to mock the location href object
  href: function(param){
    $('#content').html(param);
  }
};

'use strict';
    describe('socail-auth', function(){//FB
      var scope, compiled, linkFn, html, elem, elemPersonal, elemGroups, compile, authService;
      html = "<span id='content' data-social-auth data-network='facebook'>";
      beforeEach(function(){
        module('myApp.directives');
        module('myApp.services');

    inject(function($compile, $rootScope){
      scope = $rootScope.$new();
      linkFn = $compile(angular.element(html));
      elem = linkFn(scope);
      scope.$digest();
      elem.scope().$apply()
    });
 })
    it("should redirect user to social login url at the backend", function(){
      // console.log(location.href);
      elem.click();
      console.log($(elem).html());
      expect($(elem).html()).toBeDefined();

    });

});
like image 468
Oleg Belousov Avatar asked Nov 17 '13 10:11

Oleg Belousov


2 Answers

Use $window.location.href instead of location.href.

Then mock $window.location with an empty object, it will do the job.

describe('location', function() {
    var $window;

    beforeEach( module('myApp') );

    // You can copy/past this beforeEach
    beforeEach( module( function($provide) {

        $window = { 
            // now, $window.location.path will update that empty object
            location: {}, 
            // we keep the reference to window.document
            document: window.document
        };

        // We register our new $window instead of the old
        $provide.constant( '$window' , $window );
    }))


    // whatever you want to test
    it('should be redirected', function() {

        // action which reload the page
        $scope.reloadPage();

        // we can test if the new path is correct.
        expect( $window.location.path ).toBe('/the-url-expected');

    })
})
like image 102
Utopik Avatar answered Nov 11 '22 00:11

Utopik


The solution is to wrap the redirect to the API in a service function, and to mock it within the test to save the redirect URL in a service variable, and then expose it throught a getter method to the test instead of redirecting to it.

A mock can be done from within the test body:

module('myApp.services.mock', function($provide){
  var __service = function(){
     var __data;
     return{
        getFn: function(){
          return __data;
        },
        setFn: function: function(data){
          __data = data;
        }
     }
  }
  $provide.value('someService', __service);
});

but I choose to separate this mock intro it's own model in order to enhance structure and modularity

'use strict';
angular.module('myApp.services.mock', ['urlConfig']).
    factory('utils', function(API_URL, $location, $rootScope, $window){
        var __redirectURL = $window.location.href;
        var utilsMock = {
          getBaseUrl: function(){
              return API_URL;
          },
          getLocationHref: function(){
              return __redirectURL;
          },
          setLocationHref: function(redirectURL){
            $rootScope.$apply(function(){
                __redirectURL = redirectURL;
            });

          },
          cleanSocialSearch: function(){
              $location.search('auth_success', null);
              $location.search('auth_error', null);
              $location.search('auth_media', null);
              $location.search('personalShare', null);
              $location.search('groupShare', null);
          }
        }
        return utilsMock;
    });

--

__app.directive('socialAuth', function(utils, $location){
    return{
            restrict: 'A',
            scope: false,
            link: function(scope, elem, attrs){
                elem.bind('click', function(){
                            utils.cleanSocialSearch();
                            if(attrs.checkbox == 'personal'){
                              scope.$apply(function(){
                                scope.model.personalShare[attrs.network] = true;  
                                $location.search('personalShare', '1');
                              });
                            }
                            else if(attrs.checkbox == 'group'){
                              scope.$apply(function(){
                                var __index = attrs.checkbox + '_' + attrs.network;
                                scope.model.personalShare[__index] = true;  
                                $location.search('groupShare', '1');
                              });
                            }
                              var callback = encodeURIComponent(utils.getLocationHref());
                              var loginUrl = utils.getBaseUrl() + '/social/login/' + attrs.network + '?success_url=' + callback;
                              utils.setLocationHref(loginUrl);  

                        });
            }
    }

});

And finally the test:

describe('socail-auth', function(){//FB
  var scope, compiled, linkFn, utils, html, elem, elemPersonal, elemGroups, compile, authService, utilsMock, _window, BASE_URL, __network;
  __network = 'facebook';
  html = "<span data-social-auth data-network='" + __network + "'></span>";

  beforeEach(function(){
    module('urlConfig');
    module('myApp.services.mock');
    module('myApp.directives');
    inject(function($compile, $rootScope, $injector){
      scope = $rootScope.$new();
      utils = $injector.get('utils');
      _window = $injector.get('$window');
      BASE_URL = $injector.get('API_URL');
      linkFn = $compile(angular.element(html));
      elem = linkFn(scope);
      // scope.$digest();
      elem.scope().$apply()  
    });
 })
    it("should redirect user to social login url at the backend", function(){
      elem.click();
      //scope.$digest();
      var loginUrl = BASE_URL + '/social/login/' + __network + '?success_url=' + encodeURIComponent(_window.location.href);


       expect(utils.getLocationHref()).toEqual(loginUrl);


   });
 });
like image 30
Oleg Belousov Avatar answered Nov 10 '22 23:11

Oleg Belousov