window.location.href doesn't redirect

Question

I know this is a question much discussed but I can't figure out why it does not work for me.

This is my function:

function ShowComments(){   alert("fired");  var movieShareId = document.getElementById('movieId');  //alert("found div" + movieShareId.textContent || movieShareId.innerText);  //alert("redirect location: /comments.aspx?id=" + movieShareId.textContent || movieShareId.innerText + "/");  window.location.href = "/comments.aspx?id=" + movieShareId.textContent || movieShareId.innerText + "/";  var newLocation = window.location;  //alert("full location: " + window.location);  } 

If I have the alerts uncommented or if I have Mozilla's bugzilla open it works fine, otherwise it does not redirect to the other page.

Any ideas why?

Answer 1

If you are calling this function through a submit button. This may be the reason why the browser does not redirect. It will run the code in the function and then submit the page instead of redirect. In this case change the type tag of your button.

Answer 2

From this answer,

window.location.href not working

you just need to add

return false; 

at the bottom of your function