Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Why is this Go code blocking?

Tags:

go

goroutine

I wrote the following program:

package main

import (
    "fmt"
)

func processevents(list chan func()) {
    for {
        //a := <-list
        //a()
    }
}

func test() {
    fmt.Println("Ho!")
}

func main() {

    eventlist := make(chan func(), 100)

    go processevents(eventlist)

    for {
        eventlist <- test
        fmt.Println("Hey!")
    }
}

Since the channel eventlist is a buffered channel, I think I should get at exactly 100 times the output "Hey!", but it is displayed only once. Where is my mistake?

like image 769
Dirk Avatar asked Sep 13 '12 19:09

Dirk


2 Answers

Update (Go version 1.2+)

As of Go 1.2, the scheduler works on the principle of pre-emptive multitasking. This means that the problem in the original question (and the solution presented below) are no longer relevant.

From the Go 1.2 release notes

Pre-emption in the scheduler

In prior releases, a goroutine that was looping forever could starve out other goroutines on the same thread, a serious problem when GOMAXPROCS provided only one user thread. In Go > 1.2, this is partially addressed: The scheduler is invoked occasionally upon entry to a function. This means that any loop that includes a (non-inlined) function call can be pre-empted, allowing other goroutines to run on the same thread.

Short answer

It is not blocking on the writes. It is stuck in the infinite loop of processevents. This loop never yields to the scheduler, causing all goroutines to lock indefinitely.

If you comment out the call to processevents, you will get results as expected, right until the 100th write. At which point the program panics, because nobody reads from the channel.

Another solution is to put a call to runtime.Gosched() in the loop.

Long answer

With Go1.0.2, Go's scheduler works on the principle of Cooperative multitasking. This means that it allocates CPU time to the various goroutines running within a given OS thread by having these routines interact with the scheduler in certain conditions. These 'interactions' occur when certain types of code are executed in a goroutine. In go's case this involves doing some kind of I/O, syscalls or memory allocation (in certain conditions).

In the case of an empty loop, no such conditions are ever encountered. The scheduler is therefore never allowed to run its scheduling algorithms for as long as that loop is running. This consequently prevents it from allotting CPU time to other goroutines waiting to be run and the result you observed ensues: You effectively created a deadlock that can not be detected or broken out of by the scheduler.

The empty loop is usually never desired in Go and will, in most cases, indicate a bug in the program. If you do need it for whatever reason, you have to manually yield to the scheduler by calling runtime.Gosched() in every iteration.

for {
    runtime.Gosched()
}

Setting GOMAXPROCS to a value > 1 was mentioned as a solution. While this will get rid of the immediate problem you observed, it will effectively move the problem to a different OS thread, if the scheduler decides to move the looping goroutine to its own OS thread that is. There is no guarantee of this, unless you call runtime.LockOSThread() at the start of the processevents function. Even then, I would still not rely on this approach to be a good solution. Simply calling runtime.Gosched() in the loop itself, will solve all the issues, regardless of which OS thread the goroutine is running in.

like image 149
jimt Avatar answered Sep 23 '22 05:09

jimt


Here is another solution - use range to read from the channel. This code will yield to the scheduler correctly and also terminate properly when the channel is closed.

func processevents(list chan func()) {
    for a := range list{
        a()
    }
}
like image 45
Nick Craig-Wood Avatar answered Sep 23 '22 05:09

Nick Craig-Wood