I fully appreciate the atomicity that the Threading.Interlocked class provides; I don't understand, though, why the Add function only offers two overloads: one for Integers, another for Longs. Why not Doubles, or any other numeric type for that matter?
Clearly, the intended method for changing a Double is CompareExchange; I am GUESSING this is because modifying a Double is a more complex operation than modifying an Integer. Still it isn't clear to me why, if CompareExchange and Add can both accept Integers, they can't also both accept Doubles.
Others have addressed the "why?". It is easy however to roll your own Add(ref double, double)
, using the CompareExchange
primitive:
public static double Add(ref double location1, double value) { double newCurrentValue = location1; // non-volatile read, so may be stale while (true) { double currentValue = newCurrentValue; double newValue = currentValue + value; newCurrentValue = Interlocked.CompareExchange(ref location1, newValue, currentValue); if (newCurrentValue == currentValue) return newValue; } }
CompareExchange
sets the value of location1
to be newValue
, if the current value equals currentValue
. As it does so in an atomic, thread-safe way, we can rely on it alone without resorting to locks.
Why the while (true)
loop? Loops like this are standard when implementing optimistically concurrent algorithms. CompareExchange
will not change location1
if the current value is different from currentValue
. I initialized currentValue
to location1
- doing a non-volatile read (which might be stale, but that does not change the correctness, as CompareExchange
will check the value). If the current value (still) is what we had read from location
, CompareExchange
will change the value to newValue
. If not, we have to retry CompareExchange
with the new current value, as returned by CompareExchange
.
If the value is changed by another thread until the time of our next CompareExchange
again, it will fail again, necessitating another retry - and this can in theory go on forever, hence the loop. Unless you are constantly changing the value from multiple threads, CompareExchange
will most likely be called only once, if the current value is still what the non-volatile read of location1
yielded, or twice, if it was different.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With