Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Why is softKeys() deprecated in Guava 10?

Tags:

java

guava

As of Guava 10, MapMaker.softKeys is deprecated, and the corresponding method doesn't exist in CacheBuilder.

Why was this change made? What do I need to do with existing code that use it?

like image 612
Chris Jester-Young Avatar asked Oct 01 '11 04:10

Chris Jester-Young


2 Answers

I wrote the question because, initially, I did genuinely wonder why (as I had existing code that used softKeys). However, the reason was obvious on reflection and I decided to post it here, in case someone else also uses softKeys and was wondering the same thing.

In short, the reason was that softKeys never made any sense in the first place. Thus, its initial inclusion was in itself a mistake, one which the Guava developers are rectifying via deprecation.

In general, you use soft references if you want the object to stick around for a little after all the strong references are gone; in contrast, with weak references, the object usually gets collected soon once there are no strong or soft references left. This is useful for cached values that you want to hold on to temporarily, so that a lookup using the corresponding key will "revive" a strong reference for the value.

However, this behaviour doesn't make any sense for keys:

  • Since softKeys and weakKeys maps use an identity-based lookup, the only way to get at an entry of interest is to posess a strong reference to its key. Thus, once there are no strong key references left, the entry is effectively dead (with no possibility of revival).
  • The only practical difference between softKeys and weakKeys is how long an entry remains in the map after all the strong references to its key are gone. Since such entries are dead anyway, using softKeys instead of weakKeys only delays the entry's eviction, for no good reason.

Thus, most times when coming across code that uses softKeys, a much more suitable replacement is weakKeys.

† I am not considering the case of fetching the entry via iteration, or anything other than key-based lookup, since maps are primarily about key-based operations.

like image 113
Chris Jester-Young Avatar answered Nov 11 '22 05:11

Chris Jester-Young


Here is my attempt of explanation of the issue (a little more complete to Chris' response)

http://groups.google.com/group/guava-discuss/browse_thread/thread/764af1e627d6fa0e?pli=1

like image 7
Dimitris Andreou Avatar answered Nov 11 '22 05:11

Dimitris Andreou