Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Why getting multiple instances of IMemoryCache in ASP.Net Core?

I have what I believe is a standard usage of IMemoryCache in my ASP.NET Core application.

In startup.cs I have:

services.AddMemoryCache();

In my controllers I have:

private IMemoryCache memoryCache;
public RoleService(IMemoryCache memoryCache)
{
    this.memoryCache = memoryCache;
}

Yet when I go through debug, I end up with multiple memory caches with different items in each one. I thought memory cache would be a singleton?

Updated with code sample:

public List<FunctionRole> GetFunctionRoles()
{
    var cacheKey = "RolesList";
    var functionRoles = this.memoryCache.Get(cacheKey) as List<FunctionRole>;
    if (functionRoles == null)
    {
         functionRoles = this.functionRoleDAL.ListData(orgId);
         this.memoryCache.Set(cacheKey, functionRoles, new MemoryCacheEntryOptions().SetAbsoluteExpiration(TimeSpan.FromDays(1)));
    }
}

If I run two clients in two different browsers, when I hit the second line I can see this.memoryCache contains different entries.

like image 276
Jeff - Software Results Avatar asked Mar 13 '17 07:03

Jeff - Software Results


2 Answers

The reason that IMemoryCache is created multiple times is that your RoleService most likely gets scoped dependencies.

To fix it simply add a new singleton service containing the memory cache and inject in when needed instead of IMemoryCache:

// Startup.cs:

services.AddMemoryCache();
services.AddSingleton<CacheService>();

// CacheService.cs:

public IMemoryCache Cache { get; }

public CacheService(IMemoryCache cache)
{
  Cache = cache;
}

// RoleService:

private CacheService cacheService;
public RoleService(CacheService cacheService)
{
    this.cacheService = cacheService;
}
like image 188
too Avatar answered Oct 12 '22 10:10

too


I did NOT find a reason for this. However, after further reading I swapped from IMemoryCache to IDistributedCache using the in-memory distributed cache and the problem is no longer occurring. I figured going this route would allow me to easily update to a redis server if I needed multiple servers later on.

like image 43
Jeff - Software Results Avatar answered Oct 12 '22 10:10

Jeff - Software Results