I thought throwing an exception is good practice to let it bubble back up to the UI or somewhere where you log the exception and notify the user about it.
Why does resharper say it is redundant?
try
{
File.Open("FileNotFound.txt", FileMode.Open);
}
catch
{
throw;
}
Because
try {
File.Open("FileNotFound.txt", FileMode.Open);
} catch {
throw;
}
is no different than
File.Open("FileNotFound.txt", FileMode.Open);
If the call to File.Open(string, FileMode)
fails, then in either sample the exact same exception will find its way up to the UI.
In that catch
clause above, you are simply catching and re-throwing an exception without doing anything else, such as logging, rolling back a transaction, wrapping the exception to add additional information to it, or anything at all.
However,
try {
File.Open("FileNotFound.txt", FileMode.Open);
} catch(Exception ex) {
GetLogger().LogException(ex);
throw;
}
would not contain any redundancies and ReSharper should not complain. Likewise,
try {
File.Open("FileNotFound.txt", FileMode.Open);
} catch(Exception ex) {
throw new MyApplicationException(
"I'm sorry, but your preferences file could not be found.", ex);
}
would not be redundant.
Because the above statement has the same behavior as if it were not there. Same as writing:
File.Open("FileNotFound.txt", FileMode.Open);
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With