Which layer should be used for conversion to DTO from Domain Object

Question

We are creating rest api's with Spring Boot. We have three layers in our project(Repository, Service and Controller).

Lets say I have GetUser api in my controller that return UserDTO object.

@GetMapping public UserDTO getUser() {    return userService.getUser();     } 

Whether userService.getUser() returns UserDTO object or it returns User object and it is converted to UserDTO object in the controller? Which one is better way?

Shortly, domain object to DTO object conversion, should be done in service layer or controller layer?

Answer 1

I think there is no "better way" for converting your domain objects to your DTO objects, it's a matter of taste. In my projects I convert the domain objects to the DTO in the service layer as part of my "business logic". So you reduce the accessability of your domain objects only to your service layer. Furthermore I want to reduce the "logic" inside my controllers as they are part of the application layer.

PS: If you are looking for several ways to convert your domain objects to your DTOs have look at one of my latest Stackoverflow questions (How to properly convert domain entities to DTOs while considering scalability & testability)